Edgewall Software
Modify

Opened 11 years ago

Closed 11 years ago

#11236 closed enhancement (fixed)

Sort external services by performance

Reported by: Dirk Stöcker Owned by: Dirk Stöcker
Priority: normal Milestone: plugin - spam-filter
Component: plugin/spamfilter Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Currently external services are called always in the same order.

To improve speed for each service following data could be collected:

  • Answer time
  • missing answers/timeouts/connection failures
  • valid answers (based on training results)
  • answer time for training calls (use to skip training?)

Services with better performance should be preferred when calling external services.

Attachments (0)

Change History (6)

comment:1 by Christian Boos, 11 years ago

Probably [OT], but… this morning I was looking at the logs searching for how the SpamFilter reacted to a spam that came at 9:05 AM (on #8295). It wasn't visible in the spam monitoring, so I wonder, did someone delete that entry or the spam filter didn't catch it for some reason (timeout or so)? There was also no error in the Trac log.

in reply to:  1 ; comment:2 by Ryan J Ollos, 11 years ago

Replying to cboos:

Probably [OT], but… this morning I was looking at the logs searching for how the SpamFilter reacted to a spam that came at 9:05 AM (on #8295). It wasn't visible in the spam monitoring, so I wonder, did someone delete that entry or the spam filter didn't catch it for some reason (timeout or so)? There was also no error in the Trac log.

I've been noticing on t-h.o that entries no longer appear on the Spam Monitoring page after the spam is deleted. I haven't looked at the issue closely, but this has been unexpected since in earlier versions of SpamFilter an entry was still present on the Spam Monitoring page after the spam was deleted. With the previous behavior I could delete the spam and then mark the entry as spam, which would presumably result in that entry being used to better train the filter.

in reply to:  2 ; comment:3 by Dirk Stöcker, 11 years ago

Replying to rjollos:

Replying to cboos:

Probably [OT], but… this morning I was looking at the logs searching for how the SpamFilter reacted to a spam that came at 9:05 AM (on #8295). It wasn't visible in the spam monitoring, so I wonder, did someone delete that entry or the spam filter didn't catch it for some reason (timeout or so)? There was also no error in the Trac log.

I've been noticing on t-h.o that entries no longer appear on the Spam Monitoring page after the spam is deleted. I haven't looked at the issue closely, but this has been unexpected since in earlier versions of SpamFilter an entry was still present on the Spam Monitoring page after the spam was deleted. With the previous behavior I could delete the spam and then mark the entry as spam, which would presumably result in that entry being used to better train the filter.

Im not sure what you mean? You have three sets of buttons: One to "mark as ham/spam, train and keep", one to "mark as ham/spam, train and delete" and one to delete only. "Delete as Spam" is preferred, as you can't double train with it.

in reply to:  3 comment:4 by Ryan J Ollos, 11 years ago

Replying to dstoecker:

Im not sure what you mean? You have three sets of buttons: One to "mark as ham/spam, train and keep", one to "mark as ham/spam, train and delete" and one to delete only. "Delete as Spam" is preferred, as you can't double train with it.

I didn't think this all the way through. I've been deleting the spam directly from the ticket using the tracopt.ticket.TicketDeleter component. I did a test just now and found that the entries are still present in the spam monitoring table after a ticket or ticket comment has been deleted using TicketDeleter. I had thought this was not the case, but I must have been overlooking the spam entries in the table previously. Sorry for my confusing statements!

Last edited 11 years ago by Ryan J Ollos (previous) (diff)

comment:5 by Dirk Stöcker, 11 years ago

In r12482 - first interface for statistics, no data storage in db yet.

comment:6 by Dirk Stöcker, 11 years ago

Resolution: fixed
Status: newclosed

In r12525.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Dirk Stöcker.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Dirk Stöcker to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.