Edgewall Software
Modify

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#11186 closed enhancement (fixed)

Internal error when adding repository with a name that already exists in the database

Reported by: Ryan J Ollos <ryan.j.ollos@…> Owned by: Jun Omae
Priority: normal Milestone: 1.0.2
Component: admin/web Version: 1.0-stable
Severity: normal Keywords: repository
Cc: Branch:
Release Notes:

Show an explicit message when attempting to add a repository that already exists through the Manage Repository.

API Changes:

Description

The admin panels such as Component display a TracError when attempting to add an entry that already exists.

In Trac 1.0-stable, a TracError is not raised when attempting to add a repository entry through the Manage Repositories admin panel when the repository name already exists. An Internal Error results.

Attachments (1)

InternalError.png (66.0 KB ) - added by Ryan J Ollos <ryan.j.ollos@…> 6 years ago.

Download all attachments as: .zip

Change History (6)

by Ryan J Ollos <ryan.j.ollos@…>, 6 years ago

Attachment: InternalError.png added

comment:1 by Ryan J Ollos <ryan.j.ollos@…>, 6 years ago

Fix and functional testcase in fd1680f2.

comment:2 by Jun Omae, 6 years ago

Milestone: 1.0.2
Owner: set to Jun Omae
Status: newassigned

Looks good! I'll merge it later.

comment:3 by Jun Omae, 6 years ago

I've tried. Your changes works fine. In addition, the "Add Alias" in repository admin has the same issue. It is fixed to catch IntegrityError in [32072a92/jomae.git].

Well, "Modify Repository" has the same issue and makes unfortunately repository names duplicated. Also, 0.12-stable has the issue.

$ sqlite3 /tmp/trac-1.0.1/db/trac.db 'select * from repository'
1|name|blah22
1|dir|/var/svn/blah11
1|type|svn
2|name|blah22
2|dir|/var/svn/blah22
2|type|svn
1|url|
1|description|
Last edited 6 years ago by Jun Omae (previous) (diff)

comment:4 by Jun Omae, 6 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Committed in [11809]. Thanks, Ryan!

comment:5 by Ryan J Ollos <ryan.j.ollos@…>, 6 years ago

Keywords: repository added

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Jun Omae to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.