linksleeve error when hitting timeout

[Christian Boos]

In the t.e.o logs for this Trac, I see a bunch of these:

Trac[filtersystem] ERROR: Filter strategy <tracspamfilter.filters.linksleeve.LinkSleeveFilterStrategy object at 0x7fe55c8315d0> raised exception: TimeoutHTTPConnection instance has no attribute 'getreply'
Traceback (most recent call last):
  File "/usr/local/virtualenv/1.1dev/lib/python2.6/site-packages/TracSpamFilter-0.8.0dev_r11751-py2.6.egg/tracspamfilter/filtersystem.py", line 213, in test
    retval = strategy.test(req, author, content, ip)
  File "/usr/local/virtualenv/1.1dev/lib/python2.6/site-packages/TracSpamFilter-0.8.0dev_r11751-py2.6.egg/tracspamfilter/filters/linksleeve.py", line 46, in test
    if TimeoutServerProxy('http://www.linksleeve.org/slv.php').slv(content) != 1:
  File "/usr/lib/python2.6/xmlrpclib.py", line 1199, in __call__
    return self.__send(self.__name, args)
  File "/usr/lib/python2.6/xmlrpclib.py", line 1489, in __request
    verbose=self.__verbose
  File "/usr/lib/python2.6/xmlrpclib.py", line 1237, in request
    errcode, errmsg, headers = h.getreply()
AttributeError: TimeoutHTTPConnection instance has no attribute 'getreply'

(running TracSpamFilter-0.8.0dev_r11751-py2.6.egg)

[Dirk Stöcker]

Please try following and tell me results.

tracspamfilter/timeoutserverproxy.py

@@ -28 +28 @@
     def make_connection(self, host):
         conn = TimeoutHTTPConnection(host,self.timeout)
         return conn
+    # python 2.6, in 2.7 _conn is directly a HTTPConnection
+    def getreply(self):
+        response = self._conn.getresponse()
+        return response.status, response.reason, response.msg
 
 class TimeoutServerProxy(ServerProxy):
     def __init__(self,uri,timeout=3,*l,**kw):

[Christian Boos]

Done (running 0.8.0dev-r11782 + patch). Let's see how it behaves now.

[Christian Boos]

Hm, no, same error:

[pid 13715 139956728231680] 2013-04-28 07:14:49,452 Trac[filtersystem] ERROR: Filter strategy <tracspamfilter.filters.linksleeve.LinkSleeveFilterStrategy object at 0x7f4a46cc37d0> raised exception: TimeoutHTTPConnection instance has no attribute 'getreply'
Traceback (most recent call last):
  File "/usr/local/virtualenv/1.1dev/lib/python2.6/site-packages/TracSpamFilter-0.8.0dev_r11782-py2.6.egg/tracspamfilter/filtersystem.py", line 213, in test
    retval = strategy.test(req, author, content, ip)
  File "/usr/local/virtualenv/1.1dev/lib/python2.6/site-packages/TracSpamFilter-0.8.0dev_r11782-py2.6.egg/tracspamfilter/filters/linksleeve.py", line 46, in test
    if TimeoutServerProxy('http://www.linksleeve.org/slv.php').slv(content) != 1:
  File "/usr/lib/python2.6/xmlrpclib.py", line 1199, in __call__
    return self.__send(self.__name, args)
  File "/usr/lib/python2.6/xmlrpclib.py", line 1489, in __request
    verbose=self.__verbose
  File "/usr/lib/python2.6/xmlrpclib.py", line 1237, in request
    errcode, errmsg, headers = h.getreply()
AttributeError: TimeoutHTTPConnection instance has no attribute 'getreply'

I'm now trying this:

tracspamfilter/timeoutserverproxy.py

@@ -20 +20 @@
 class TimeoutHTTPConnection(httplib.HTTPConnection):
     def __init__(self,host,timeout=3):
         httplib.HTTPConnection.__init__(self,host,timeout=timeout)
+
+    # in python 2.6, xmlrpclib expects to use an httplib.HTTP
+    # instance and will call getreply() and getfile()
+
+    def getreply(self):
+        response = self.getresponse()
+        self.file = response.fp
+        return response.status, response.reason, response.msg
+
+    def getfile(self):
+        return self.file
 
+
 class TimeoutTransport(Transport):
     def __init__(self, timeout=3, *l, **kw):
         Transport.__init__(self,*l,**kw)
         self.timeout=timeout
+
     def make_connection(self, host):
         conn = TimeoutHTTPConnection(host,self.timeout)
         return conn
 
+
 class TimeoutServerProxy(ServerProxy):
     def __init__(self,uri,timeout=3,*l,**kw):
         kw['transport']=TimeoutTransport(timeout=timeout, use_datetime=kw.get('use_datetime',0))

… and while trying to spam this ticket, I got a "LinkSleeve says this is spam" message on the rejection page, without a backtrace in the log, so I think it must work.

[Dirk Stöcker]

Verified? Should I add the patch?

[Christian Boos]

Yes, for me (well, here on t.e.o) it works. I was giving it a few more days to see if anything else popped up in the .log, but it seems alright.

I can directly commit the patch from there, if that's OK for you.

[Dirk Stöcker]

Sure.

[Christian Boos]

Applied in r11796.