Edgewall Software
Modify

Opened 20 years ago

Closed 16 years ago

Last modified 16 years ago

#1115 closed defect (worksforme)

default_charset option not working

Reported by: trustin@… Owned by: Jonas Borgström
Priority: normal Milestone:
Component: version control Version: 0.11
Severity: normal Keywords: source charset unicode verify
Cc: tiger@…, dlin@… Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Source browser assumes the encoding of source codes is UTF-8. It would be nice if trac can auto-detect the actual encoding or use the config entry from trac.ini, and convert them to UTF-8 using iconv.

Attachments (0)

Change History (14)

comment:1 by anonymous, 20 years ago

Component: generalbrowser

comment:2 by anonymous, 20 years ago

Priority: normalhighest
Severity: normalcritical

comment:3 by Christopher Lenz, 20 years ago

Keywords: charset added; browse encoding removed
Priority: highestnormal
Resolution: worksforme
Severity: criticalnormal
Status: newclosed

TracIni has a default_charset option for this:

[trac]
default_charset = iso-8859-1

comment:4 by twenim@…, 20 years ago

Resolution: worksforme
Status: closedreopened

Default_charset option is not working

Environment

  • OS : RedHat 9
  • Environment variable : LANG=ko_KR.eucKR
  • Trac.ini :
    [trac]
    default_charset = iso-8859-1
    

example

검색:      Navigation
twe로 로그인 로그아웃 설정 도움말 
FAQ 
접근성 
Trac에 대해 
위키 시간 순 이력 로드맵 소스 둘러보기 티켓 보기 티켓 등록 검색 
Revision Log 
root/trunk/xdocs/회의록/2005010402 요구사항과 계획수립.txt
View revision:  Revision 2 (by twe, 01/10/05 17:34:48)  최초 임포트 
 

¡Ü À¯ÁîÄÉÀ̽º
- ÀÎÅͺä´ë»óÀÚ : Áö¿¬½Ä, ÀÌÁÖ¿±, »çÀå´Ô, ±è°æÅÂ, ½Å¿ë¼ö, °­Á¤¿Ï, ±èÀÎÈ£, ½ÉÁØÇö
- ÀÎÅͺ丮Æ÷Æ®

- »ç¿ø °ü¸® : Á¶Á÷µµ, »ç¿ø, ºÎ¼­, ÀÎÁõ, ±ÇÇѼ³Á¤, ±ÙÅÂ, ÃâÅð±Ù, Á÷±Þ
- Task °ü¸® (ÇöÀçÂÊÁö, À̽´°ü¸®, ÀÏÁ¤°ü¸®, ÀüÀÚ°áÀç Æ÷ÇÔ)

comment:5 by Christopher Lenz, 20 years ago

Summary: Source browser should support other encodings than UTF-8default_charset option not working

Shouldn't you be using a default_charset of euc-kr instead of iso-8859-1 there?

comment:6 by twenim@…, 20 years ago

Resolution: worksforme
Status: reopenedclosed

comment:7 by tiger@…, 20 years ago

Component: browserchangeset view
Resolution: worksforme
Status: closedreopened
Version: 0.8devel

default_charset works for code browser but does not affect for changeset view. Native chars in diffs' display are jammed.

comment:8 by Christopher Lenz, 20 years ago

What exact revision are you using? This looks related to #1556 and #1457, both of which should be fixed in trunk.

comment:9 by tiger@…, 20 years ago

Cc: tiger@… added

I'm using [1585]. I can't upgrade to latest trunk version to check if this issue exists there as well due to #1535.

Instead of national chars there is ?????? sequences in the changest view, but the commit log message in the top of the page is ok.

comment:10 by Christian Boos, 19 years ago

Milestone: 0.10
Resolution: fixed
Status: reopenedclosed

I believe this should now work correctly in 0.10.

comment:11 by dlin@…, 16 years ago

Cc: dlin@… added
Component: version control/changeset viewi18n
Milestone: 0.100.11.2
Resolution: fixed
Status: closedreopened
Version: devel0.11

I use trac v0.11 + mercurial + apache

I've set the apache's httpd.conf

PythonOption TracLocale zh_TW.utf8

And trac.ini [trac] default_charset = big5

It can't work, I remember it workable in 0.10, is that caused by genshi? Now, I can display Chinese in trac's page, but can NOT display source code which is big5 coded.

comment:12 by Christian Boos, 16 years ago

Component: i18nversion control
Keywords: unicode verify added
Milestone: 0.11.20.11.3

comment:13 by Jonas Borgström, 16 years ago

Resolution: worksforme
Status: reopenedclosed

I just verified that Trac correctly displays big5 encoded files with default_charset = big5.

I tested this with files both in a subversion repository and as ticket attachments.

Please reopen this if you still can reproduce this somehow.

comment:14 by Christian Boos, 16 years ago

Milestone: 0.11.3

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jonas Borgström.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jonas Borgström to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.