Edgewall Software
Modify

Opened 6 years ago

Last modified 2 weeks ago

#11142 new enhancement

Add download link in attachment section

Reported by: Dirk Stöcker Owned by:
Priority: normal Milestone: next-major-releases
Component: attachment Version:
Severity: normal Keywords:
Cc: Ryan J Ollos Branch:
Release Notes:
API Changes:

Description

Currently to download an attachment you need to view it, scroll down and then click on the plain link. Most of the cases I don't want to view it, but rather want to have it.

Please add a direct download link in the attachment section of wiki pages (and tickets). Would save a lot of time on user side and does not really have any negative side effects.

Attachments (2)

new-attachment-dl.png (24.4 KB ) - added by Christian Boos 6 years ago.
raw attachment links on the left
t11142-size-download-links.png (14.2 KB ) - added by Christian Boos 5 years ago.
Alternative placement of the raw download links in the attachment list

Download all attachments as: .zip

Change History (27)

comment:1 by Christian Boos, 6 years ago

Resolution: worksforme
Status: newclosed

And what about the raw download links you'll find on the download.png icons?

comment:2 by Dirk Stöcker, 6 years ago

Never seen that. Maybe it can be moved behind the size, so that there is a little visual distinction?

comment:3 by Jun Omae, 6 years ago

In the former case, it would be good to add download link to #ctxtnav in attachment view.

in reply to:  2 ; comment:4 by Ryan J Ollos <ryan.j.ollos@…>, 6 years ago

Replying to dstoecker:

Never seen that. Maybe it can be moved behind the size, so that there is a little visual distinction?

What if we moved it over to the left, possibly replacing the list bullet?

download.png ReportEdit.png​ (39.9 KB)


by Christian Boos, 6 years ago

Attachment: new-attachment-dl.png added

raw attachment links on the left

in reply to:  4 comment:5 by Christian Boos, 6 years ago

Replying to Ryan J Ollos <ryan.j.ollos@…>:

Replying to dstoecker:

Never seen that. Maybe it can be moved behind the size, so that there is a little visual distinction?

What if we moved it over to the left, possibly replacing the list bullet?

Expanded example… like this?

raw attachment links on the left

comment:6 by Ryan J Ollos <ryan.j.ollos@…>, 6 years ago

Cc: ryan.j.ollos@… added

Yes! I like it a lot. I could work up a patch, but it looks like you might already have it implemented for the most part?

in reply to:  6 comment:7 by Christian Boos, 6 years ago

Replying to Ryan J Ollos <ryan.j.ollos@…>:

Yes! I like it a lot. I could work up a patch, but it looks like you might already have it implemented for the most part?

No, I just played around in Chrome. But I can follow-up with a patch if Dirk confirms this style is more user-friendly.

in reply to:  3 comment:8 by Christian Boos, 6 years ago

Replying to jomae:

In the former case, it would be good to add download link to #ctxtnav in attachment view.

I'm not sure about this, as I'd rather add the links to the prev/next attachments there.

comment:9 by Christian Boos, 6 years ago

Milestone: next-stable-1.0.x
Resolution: worksforme
Status: closedreopened

I've worked a bit on this topic:

comment:10 by Dirk Stöcker, 6 years ago

Hmm, I'm preoccupied now. Though before I assumed the symbol was part of the link (like the small sign for external links). Same here for a colleague of mine. I fear when you use it as bullet you have the same issue only slightly different, but anyway it looks nicer :-).

Simple test is: Take someone who usually never uses trac and ask him "to download, not to view an attachment". If he clicks the link, then placement is right.

comment:11 by Ryan J Ollos, 6 years ago

Milestone: next-stable-1.0.x1.1.3

Would anyone object to applying this change in milestone:1.1.3? My feeling is that, since no one has commented on this ticket, applying the change now is the best opportunity to get feedback on the change before the 1.2 release. That, and I strongly feel that this is a positive change to the interface, and most users will appreciate it. If not, we can tweak or revert it before the 1.2 release.

comment:12 by Remy Blank, 6 years ago

When I added the direct download links in the first place, I tried both options (placing it before and placing it after the link). IIRC we had a consensus that placing it after the link was better, as the link was the main item, and the direct download was secondary.

I agree with Dirk that placing it before the link in the attachment list makes it look like a bullet point, and therefore less likely to be clicked. I don't think that's an improvement.

To really make it better, I think there's no way around adding a more prominent "(download)" link to the attachment lists. Just playing with the small icon won't solve the issue.

Of course, the small icon is still good for attachment links in wiki text, as there it's supposed to be discrete.

comment:13 by Ryan J Ollos, 6 years ago

It occurred to me that there may also be accessibility issues with making the bullet a download link.

Regardless, I guess that the ticket should be kept open for the second and third changes in comment:9.

by Christian Boos, 5 years ago

Alternative placement of the raw download links in the attachment list

comment:14 by Christian Boos, 5 years ago

Component: generalattachment
Owner: set to Christian Boos
Status: reopenedassigned

I've rebased my original branch on trunk (cboos.git@t11142-trac-rawlink-on-the-left.1), but as there was no consensus on the download link in front of the attachment, I also tried an alternative, with the download link placed one the size information (cboos.git@t11142-trac-rawlink-on-the-left.2 - well, not really on the left this time ;-) )

The alternative looks like this:

Alternative placement of the raw download links in the attachment list

comment:15 by Ryan J Ollos, 5 years ago

Cc: Ryan J Ollos added; ryan.j.ollos@… removed

in reply to:  14 comment:16 by Ryan J Ollos, 5 years ago

Replying to cboos:

I've rebased my original branch on trunk (cboos.git@t11142-trac-rawlink-on-the-left.1),

The prev/next navigation links on the attachment page are nice. There's an uninitialised variable i when navigating to the attachment page for the case in which there are no attachments.

but as there was no consensus on the download link in front of the attachment, I also tried an alternative, with the download link placed one the size information (cboos.git@t11142-trac-rawlink-on-the-left.2 - well, not really on the left this time ;-) )

That looks good.

comment:17 by Peter Suter, 5 years ago

Just to throw in another idea: How about using captioned_button, e.g. something like <a ...>${captioned_button('📥', _('Download'))}</a>?

comment:18 by Ryan J Ollos, 5 years ago

Milestone: 1.1.31.1.4

comment:19 by Ryan J Ollos, 5 years ago

Milestone: 1.1.41.1.5

comment:20 by Ryan J Ollos, 4 years ago

Milestone: 1.1.51.1.6

Retargeting tickets that I think won't be completed for 1.1.5, but please move back if I'm incorrect.

comment:21 by Ryan J Ollos, 4 years ago

Milestone: 1.1.6next-dev-1.1.x

comment:22 by Ryan J Ollos, 4 years ago

Owner: Christian Boos removed
Status: assignednew

comment:23 by Ryan J Ollos, 4 years ago

Milestone: next-dev-1.1.xnext-dev-1.3.x

Narrowing focus for milestone:1.2. Please move ticket to milestone:1.2 if you intend to fix it.

comment:24 by Ryan J Ollos, 6 weeks ago

Milestone: next-dev-1.3.xnext-dev-1.5.x

Milestone renamed

comment:25 by Ryan J Ollos, 2 weeks ago

Milestone: next-dev-1.5.xnext-major-releases

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
The ticket will be disowned. Next status will be 'new'.
as The resolution will be set. Next status will be 'closed'.
The owner will be changed from (none) to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.