Add download link in attachment section

[Dirk Stöcker]

Currently to download an attachment you need to view it, scroll down and then click on the plain link. Most of the cases I don't want to view it, but rather want to have it.

Please add a direct download link in the attachment section of wiki pages (and tickets). Would save a lot of time on user side and does not really have any negative side effects.

[Christian Boos]

And what about the raw download links you'll find on the icons?

[Dirk Stöcker]

Never seen that. Maybe it can be moved behind the size, so that there is a little visual distinction?

[Jun Omae]

In the former case, it would be good to add download link to #ctxtnav in attachment view.

[Ryan J Ollos <ryan.j.ollos@…>]

Replying to dstoecker:

Never seen that. Maybe it can be moved behind the size, so that there is a little visual distinction?

What if we moved it over to the left, possibly replacing the list bullet?

ReportEdit.png​ (39.9 KB)

[Christian Boos]

raw attachment links on the left

[Christian Boos]

Replying to Ryan J Ollos <ryan.j.ollos@…>:

Replying to dstoecker:

Never seen that. Maybe it can be moved behind the size, so that there is a little visual distinction?

What if we moved it over to the left, possibly replacing the list bullet?

Expanded example… like this?

[Ryan J Ollos <ryan.j.ollos@…>]

Yes! I like it a lot. I could work up a patch, but it looks like you might already have it implemented for the most part?

[Christian Boos]

Replying to Ryan J Ollos <ryan.j.ollos@…>:

Yes! I like it a lot. I could work up a patch, but it looks like you might already have it implemented for the most part?

No, I just played around in Chrome. But I can follow-up with a patch if Dirk confirms this style is more user-friendly.

[Christian Boos]

Replying to jomae:

In the former case, it would be good to add download link to #ctxtnav in attachment view.

I'm not sure about this, as I'd rather add the links to the prev/next attachments there.

[Christian Boos]

I've worked a bit on this topic:

• [acd0fd76/cboos.git] ticket:11142: slightly more intuitive placement of the trac-rawlink links for the attachments.

• [49544a31/cboos.git] 1.0.2dev: add prev/next navigation links to the attachment page
• [01c11211/cboos.git] 1.0.2dev: check modification of an attachment page takes into account prev/next ids

[Dirk Stöcker]

Hmm, I'm preoccupied now. Though before I assumed the symbol was part of the link (like the small sign for external links). Same here for a colleague of mine. I fear when you use it as bullet you have the same issue only slightly different, but anyway it looks nicer :-).

Simple test is: Take someone who usually never uses trac and ask him "to download, not to view an attachment". If he clicks the link, then placement is right.

[Ryan J Ollos]

Would anyone object to applying this change in milestone:1.1.3? My feeling is that, since no one has commented on this ticket, applying the change now is the best opportunity to get feedback on the change before the 1.2 release. That, and I strongly feel that this is a positive change to the interface, and most users will appreciate it. If not, we can tweak or revert it before the 1.2 release.

[Remy Blank]

When I added the direct download links in the first place, I tried both options (placing it before and placing it after the link). IIRC we had a consensus that placing it after the link was better, as the link was the main item, and the direct download was secondary.

I agree with Dirk that placing it before the link in the attachment list makes it look like a bullet point, and therefore less likely to be clicked. I don't think that's an improvement.

To really make it better, I think there's no way around adding a more prominent "(download)" link to the attachment lists. Just playing with the small icon won't solve the issue.

Of course, the small icon is still good for attachment links in wiki text, as there it's supposed to be discrete.

[Ryan J Ollos]

It occurred to me that there may also be accessibility issues with making the bullet a download link.

Regardless, I guess that the ticket should be kept open for the second and third changes in comment:9.

[Christian Boos]

Alternative placement of the raw download links in the attachment list

[Christian Boos]

I've rebased my original branch on trunk (cboos.git@t11142-trac-rawlink-on-the-left.1), but as there was no consensus on the download link in front of the attachment, I also tried an alternative, with the download link placed one the size information (cboos.git@t11142-trac-rawlink-on-the-left.2 - well, not really on the left this time ;-) )

The alternative looks like this:

[Ryan J Ollos]

Replying to cboos:

I've rebased my original branch on trunk (cboos.git@t11142-trac-rawlink-on-the-left.1),

The prev/next navigation links on the attachment page are nice. There's an uninitialised variable i when navigating to the attachment page for the case in which there are no attachments.

but as there was no consensus on the download link in front of the attachment, I also tried an alternative, with the download link placed one the size information (cboos.git@t11142-trac-rawlink-on-the-left.2 - well, not really on the left this time ;-) )

That looks good.

[Peter Suter]

Just to throw in another idea: How about using captioned_button​, e.g. something like <a ...>${captioned_button('📥', _('Download'))}</a>?

[Ryan J Ollos]

Retargeting tickets that I think won't be completed for 1.1.5, but please move back if I'm incorrect.

[Ryan J Ollos]

Narrowing focus for milestone:1.2. Please move ticket to milestone:1.2 if you intend to fix it.

[Ryan J Ollos]

Milestone renamed