Edgewall Software
Modify

Opened 6 years ago

Last modified 4 years ago

#11130 new enhancement

Add an inlinelinkbutton class

Reported by: chris.nelson.1022@… Owned by:
Priority: normal Milestone: next-dev-1.3.x
Component: general Version:
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:

Description

The buttons plugins add to ticket pages (Create, Delete, etc.) have a range of plugin-specific styles. It would be nice to unify them. Some plugins use a button, others use a link styled as a button.

The existing inline buttons style had a relative font size but depending on where the button was in the page, it could have a different appearance. This patch makes the text size consistent.

The new inlinelinkbutton style makes links with that style look like inline buttons.

Attachments (3)

inline.diff (900 bytes ) - added by Chris.Nelson@… 6 years ago.
Patch to make inline buttons consistent, add inlinelinkbutton style
TicketCreateButtons.png (35.0 KB ) - added by Ryan J Ollos 5 years ago.
Subtickets Create Button.png (3.3 KB ) - added by Chris.Nelson@… 5 years ago.
Example of Subtickets button to create children

Download all attachments as: .zip

Change History (21)

by Chris.Nelson@…, 6 years ago

Attachment: inline.diff added

Patch to make inline buttons consistent, add inlinelinkbutton style

in reply to:  description ; comment:1 by Ryan J Ollos <ryan.j.ollos@…>, 6 years ago

Cc: ryan.j.ollos@… added

Replying to Chris.Nelson@…:

The buttons plugins add to ticket pages (Create, Delete, etc.) have a range of plugin-specific styles.

Plugins provided with Trac, tracopt.ticket.clone and tracopt.ticket.deleter, add input elements for the buttons, so it looks like the Clone and Delete buttons should be okay (and even for Trac < 0.12, the th:TicketDeletePlugin appears to add an input element within the div.inlinebuttons). You mentioned Create, and I don't think I've seen a plugin that adds a Create button.

Which other plugins on Trac add link elements?

in reply to:  1 comment:2 by Ryan J Ollos <ryan.j.ollos@…>, 6 years ago

Replying to Ryan J Ollos <ryan.j.ollos@…>:

Which other plugins on Trac add link elements?

Sorry, I meant Trac and/or Trac-Hacks.

in reply to:  1 ; comment:3 by Chris.Nelson@…, 6 years ago

Replying to Ryan J Ollos <ryan.j.ollos@…>:

Replying to Chris.Nelson@…:

The buttons plugins add to ticket pages (Create, Delete, etc.) have a range of plugin-specific styles.

Plugins provided with Trac, tracopt.ticket.clone and tracopt.ticket.deleter, add input elements for the buttons, so it looks like the Clone and Delete buttons should be okay (and even for Trac < 0.12, the th:TicketDeletePlugin appears to add an input element within the div.inlinebuttons). You mentioned Create, and I don't think I've seen a plugin that adds a Create button.

Which other plugins on Trac add link elements?

I believe SubticketsPlugin does. I know my TicketCreateButtonsPlugin plugin does.

Last edited 5 years ago by Ryan J Ollos (previous) (diff)

comment:4 by Ryan J Ollos, 5 years ago

The proposed change in [f22fa670/rjollos.git#file0] would allow adding the inlinebuttons class to a div or span that wraps a link. Would that be sufficient for your needs?

comment:5 by Ryan J Ollos, 5 years ago

Cc: ryan.j.ollos@… removed
Milestone: next-dev-1.1.x1.1.3
Owner: set to Ryan J Ollos
Status: newassigned

in reply to:  4 ; comment:6 by Chris.Nelson@…, 5 years ago

Replying to rjollos:

The proposed change in [f22fa670/rjollos.git#file0] would allow adding the inlinebuttons class to a div or span that wraps a link. Would that be sufficient for your needs?

I suspect it is inadequate because it leaves the text with a relative size so depending on the context, the buttons may have different sizes. We have a Trac 1.0 version of this but I am out of the office. I can try to attach it when I return.

in reply to:  6 comment:7 by Jun Omae, 5 years ago

Replying to Chris.Nelson@…:

Replying to rjollos:

The proposed change in [f22fa670/rjollos.git#file0] would allow adding the inlinebuttons class to a div or span that wraps a link. Would that be sufficient for your needs?

I suspect it is inadequate because it leaves the text with a relative size so depending on the context, the buttons may have different sizes. We have a Trac 1.0 version of this but I am out of the office. I can try to attach it when I return.

I've commented about tweaking style of the link buttons. See comment:11:ticket:6573.

by Ryan J Ollos, 5 years ago

Attachment: TicketCreateButtons.png added

in reply to:  3 ; comment:8 by Ryan J Ollos, 5 years ago

Replying to Chris.Nelson@…:

I believe SubticketsPlugin does. I know my TicketCreateButtonsPlugin plugin does.

I did some testing.

TicketCreateButtons adds input elements: browser:/ticketcreatebuttonsplugin/0.11/ticketCreateButtons/ticketCreateButtons.py@9441:114-115#L111. The inlinebuttons styling is applied to those.

I don't see any "actionable" links created by SubticketsPlugin.

The TicketCreateButtonsPlugin button are smaller than the buttons below the description, but that might be better fixed with some styling for TicketCreateButtonsPlugin. That would be the only open action item I see in this ticket after the changes in #6573 are committed.

in reply to:  8 comment:9 by Chris.Nelson@…, 5 years ago

Replying to rjollos:

Replying to Chris.Nelson@…:

I believe SubticketsPlugin does. I know my TicketCreateButtonsPlugin plugin does.

I did some testing.

Empirical evidence is always best!

TicketCreateButtons adds input elements: browser:/ticketcreatebuttonsplugin/0.11/ticketCreateButtons/ticketCreateButtons.py@9441:114-115#L111. The inlinebuttons styling is applied to those.

I don't see any "actionable" links created by SubticketsPlugin.

It has a button to create children. I'll attach an example.

The TicketCreateButtonsPlugin button are smaller than the buttons below the description, but that might be better fixed with some styling for TicketCreateButtonsPlugin. That would be the only open action item I see in this ticket after the changes in #6573 are committed.

Well, I'd argue that it should be trivial to create buttons like Trac does by using its style, not requiring any overrides or customization. But it's not worth a lot to me.

by Chris.Nelson@…, 5 years ago

Example of Subtickets button to create children

comment:10 by Chris.Nelson@…, 5 years ago

Subtickets plugin in 0.11.6:

Example of Subtickets button to create children

Last edited 5 years ago by Ryan J Ollos (previous) (diff)

comment:11 by Ryan J Ollos, 5 years ago

Milestone: 1.1.3next-dev-1.1.x
Owner: Ryan J Ollos removed
Status: assignednew

comment:12 by Ryan J Ollos, 4 years ago

Milestone: next-dev-1.1.x1.1.5

comment:13 by Ryan J Ollos, 4 years ago

Owner: set to Ryan J Ollos
Status: newassigned

comment:14 by Ryan J Ollos, 4 years ago

Milestone: 1.1.51.2

comment:15 by Ryan J Ollos, 4 years ago

Milestone: 1.21.1.6

Milestone renamed

comment:16 by Ryan J Ollos, 4 years ago

Milestone: 1.1.6next-dev-1.1.x
Owner: Ryan J Ollos removed
Status: assignednew

comment:17 by Ryan J Ollos, 4 years ago

Reporter: changed from Chris.Nelson@… to chris.nelson.1022@…

comment:18 by Ryan J Ollos, 4 years ago

Milestone: next-dev-1.1.xnext-dev-1.3.x

Narrowing focus for milestone:1.2. Please move ticket to milestone:1.2 if you intend to fix it.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
The ticket will be disowned.
as The resolution will be set.
The owner will be changed from (none) to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.