Add a margin around images included in wiki text using the Image macro

[Ryan J Ollos]

I noticed while looking at description:ticket:11112 that there is no margin around the images. Here is another example:

It's not so noticeable for regular text, but inline code blocks bump up against the image.

[Ryan J Ollos <ryan.j.ollos@…>]

Looking more closely at WikiMacros#Image-macro, it does have a margin option. So I guess what I'd suggest here is just a better default. The patch in ​3eb3b3a5 adds a 0.5em margin around the images contained in the #content div (so this won't apply to, e.g. the header logo image). The margin continues to be overridden if the user specifies margin in the call to the Image macro.

[Ryan J Ollos <ryan.j.ollos@…>]

Now that I look more closely, certain letters in normal text also bump against the inline code blocks.

For example:
ggggg yyyyy pppp jjj qqqqq
Some inline code block

I still like the idea of a small margin around the images, but perhaps the styling of the inline code blocks needs to be adjusted.

[Christian Boos]

We could use box-shadow: 0 0 0 1px #edc inset instead of border: 1px solid #edc, that would buy us a pixel and avoid the character descender to touch that visible border. But not all browsers would support that.

[Ryan J Ollos]

Another thing I just noticed about inline code blocks is that underscores can be hidden.

trac.utils.__init__ is fine, but
when we have two consecutives lines
trac.utils.__init__
trac.utils.__init__
the underscores of the first line are hidden.

[Ryan J Ollos]

Replying to rjollos:

Another thing I just noticed about inline code blocks is that underscores can be hidden.

This seems to be browser/platform dependent. In Chrome 30 on Win7 I can see the underscores. When I switch over to Chromium 28 on Ubuntu 13.04 in my VM (which is where I added comment:5 from yesterday), the underscores are hidden.

[Peter Suter]

See also #11154 for a request to adjust the image macro width default value.

[Jun Omae]

Replying to rjollos:

Replying to rjollos:

Another thing I just noticed about inline code blocks is that underscores can be hidden.

This seems to be browser/platform dependent. In Chrome 30 on Win7 I can see the underscores. When I switch over to Chromium 28 on Ubuntu 13.04 in my VM (which is where I added comment:5 from yesterday), the underscores are hidden.

Are you using "Courier New" font? See ​https://code.google.com/p/chromium/issues/detail?id=41457.

IMO, I don't recommend using that font since the underscore character is below its descent line, ​google:"underscore courier new".

[Ryan J Ollos]

Moved ticket assigned to next-stable-1.0.x since maintenance of 1.0.x is coming to a close. Please move the ticket back if it's critical to fix on 1.0.x.

[Ryan J Ollos]

This seems to be fixed on the trunk.