Admin Manage Components table does not hide when there are no components

[Ryan J Ollos <ryan.j.ollos@…>]

Here is a screen capture of the Manage Milestones view with all of the milestones deleted:

Here is a screen capture of the Manage Components view with all of the components deleted:

The message As long as you don't add any items to the list, this field will remain completely hidden from the user interface. should be displayed and the table header should be hidden when all of the Components are deleted.

The problem is that Component.select returns a generator, and it's not expanded to a list in _render_admin_panel. For all of the other cases of Ticket System fields, select either returns a list or the generator is expanded to a list in _render_admin_panel (e.g. enums).

[Ryan J Ollos <ryan.j.ollos@…>]

Should I just expand the generator to a list before passing to the template, or is there something else that should be done here?

[Christian Boos]

It's just "by luck" that some other select return a list and not a generator. It would look suspicious to have a 'components': list(model.Component.select(self.env)), line but then a 'versions': model.Version.select(self.env) a bit later. As we already have the list(...) for the abstract enums, I think we should better add it everywhere, to be consistent and better express that the templates actually expect a list.

Btw, I just saw we still have the ticket related admin templates still below admin/templates. It would be better to have them below the ticket/templates.

[Ryan J Ollos <ryan.j.ollos@…>]

Replying to cboos:

Btw, I just saw we still have the ticket related admin templates still below admin/templates. It would be better to have them below the ticket/templates.

Cool, I've been meaning to bring that up. I'll make that change in the Git branch for this ticket.

[Ryan J Ollos]

The Manage Repositories panel has the same issue as the Manage Components panel.