Use of deprecated env.get_version(db) in trac core

[ethan.jucovy@…]

The docstring for Environment.get_version in trac/env.py states:

        :since 1.0: deprecation warning: the `db` parameter is no                                                                                                               
                    longer used and will be removed in version 1.1.1                                                                                                            
        """

However, code in trac/env.py on trunk calls get_version(db).

The following patch removes the deprecated db argument in the function call. Trac's tests still pass after this patch is applied.

trac/env.py

@@ -754 +754 @@
         self._update_sample_config()
 
     def environment_needs_upgrade(self, db):
-        dbver = self.env.get_version(db)
+        dbver = self.env.get_version()
         if dbver == db_default.db_version:
             return False
         elif dbver > db_default.db_version:

This is the only place in Trac core code where the old signature is used — all other calls to env.get_version do not pass in the db argument.

[Christian Boos]

Good catch! It's always better to be consistent…

[Ryan J Ollos]

Committed to 1.0-stable in [11981] and merged to trunk in [11982].

Thanks Ethan!