Edgewall Software
Modify ↓

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#11080 closed enhancement (fixed)

Show info message when page is renamed

Reported by: Ryan J Ollos <ryan.j.ollos@…> Owned by: Ryan J Ollos <ryan.j.ollos@…>
Priority: low Milestone: 1.0.2
Component: wiki system Version: 1.0-stable
Severity: minor Keywords:
Cc: Branch:
Release Notes:

Display an info notice when a page is renamed.

API Changes:
Internal Changes:

Description

It would be comforting to show a notice message when a page is renamed. For example,

close The page TracGuide has been renamed to SuperAwesomeTracGuide.

This would also be more consistent with the other occurrences of a notice being added.

Attachments (2)

t11080-r11693-1.patch​ (2.2 KB ) - added by Ryan J Ollos <ryan.j.ollos@…> 12 years ago.
Patch against r11693 of the trunk.
t11080-r11693-2.patch​ (1.9 KB ) - added by Ryan J Ollos <ryan.j.ollos@…> 12 years ago.
Patch against r11693 of the trunk.

Download all attachments as: .zip

Change History (10)

by Ryan J Ollos <ryan.j.ollos@…>, 12 years ago

Attachment: t11080-r11693-1.patch​ added

Patch against r11693 of the trunk.

comment:1 by Ryan J Ollos <ryan.j.ollos@…>, 12 years ago

t11080-r11693-1.patch​ is against the current trunk. I figured that since there are translatable strings being added, this can't be included in 1.0.2. Is it okay to put the add_notices within the with block? It keeps the logic simpler when adding a separate message for the redirect case.

comment:2 by Remy Blank, 12 years ago

Looks good, but please place the add_notice() calls outside (at the end of) the transaction block. The notice would be confusing if the transaction was aborted due to an exception (it would be shown anyway).

in reply to:  1 comment:3 by Christian Boos, 12 years ago

Replying to Ryan J Ollos <ryan.j.ollos@…>:

[…] since there are translatable strings being added, this can't be included in 1.0.2.

Well, we usually try to enforce a string freeze some weeks before a release, but other than that, it's OK to add new texts.

by Ryan J Ollos <ryan.j.ollos@…>, 12 years ago

Attachment: t11080-r11693-2.patch​ added

Patch against r11693 of the trunk.

comment:4 by Ryan J Ollos <ryan.j.ollos@…>, 12 years ago

t11080-r11693-2.patch​ incorporates the suggestion from comment:2, and applies cleanly against branches/1.0-stable​.

comment:5 by Ryan J Ollos <ryan.j.ollos@…>, 12 years ago

I've also applied the patch to ​3529c2d4, a Git branch of the latest 1.0-stable as of this writing. Let me know if that helps at all when pulling this in, or if there is anything else I can to make the process easier.

Here is the resulting message for the case that a redirect is added:

close
  • The page WikiStart has been renamed to WikiStop.
  • The page WikiStart has been created with a redirect to WikiStop.

comment:6 by Christian Boos, 12 years ago

Milestone: → 1.0.2
Resolution: → fixed
Status: new → closed

Applied in r11699, thanks!

And I changed created to recreated.

comment:7 by Christian Boos, 12 years ago

Owner: set to Ryan J Ollos <ryan.j.ollos@…>

comment:8 by Ryan J Ollos <ryan.j.ollos@…>, 12 years ago

Release Notes: modified (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos <ryan.j.ollos@…>.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos <ryan.j.ollos@…> to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.