Edgewall Software

Opened 11 years ago

Last modified 11 years ago

#11059 closed defect

jquery ui css has overescaped backslashes — at Initial Version

Reported by: Elan Ruusamäe <glen@…> Owned by:
Priority: normal Milestone: 1.0.2
Component: general Version: 1.0.1
Severity: minor Keywords: jqueryui css
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

jquery ui custom css has overescaped backslashes, due previous, or even current bug in the theme generator. most common case is that php magic quotes is enabled (in theme roller), and it's php code does not issue stripslashes properly when rendering the from with POST data again.

current state is that each time theme is regenerated, TRAC provides already overescaped url, imho it should be manually cleaned from URL and from Font name itself.

13:22:58  glen> hi. i noticed trac jquery-ui theme has excess of backslashes
13:23:01  glen> http://trac.edgewall.org/browser/trunk/trac/htdocs/css/jquery-ui/jquery-ui.css#L229
13:23:48  glen> is it some kind of clever IE hack, or just jquery-ui themeroller magic quotes thing extending \ to \\ with each "save" (originally expanded from ' -> \') ? and
                nobody noticed it?
13:34:20  osimons> glen: the jquery-ui module is added to trac as-is, you question is likely better asked in #jquery
14:27:13  glen> osimons: nope. it's "customized" version, based on input params "you" provided
14:27:26  glen> and the input already contains dozens of %5C (urlencoded \)
14:27:40  glen> the expansion of \ may be fixed, but trac provides it's own
Day changed to 06 veebr 2013

Change History (0)

Note: See TracTickets for help on using tickets.