jquery ui css has overescaped backslashes

[Elan Ruusamäe <glen@…>]

​jquery ui custom css has overescaped backslashes, due previous, or even current bug in the ​theme generator. most common case is that ​php magic quotes is enabled (in theme roller), and it's php code does not issue ​stripslashes properly when rendering the from with POST data again.

current state is that each time theme is regenerated, TRAC provides already overescaped url, imho it should be manually cleaned from ​URL and from ​Font name itself.

13:22:58  glen> hi. i noticed trac jquery-ui theme has excess of backslashes
13:23:01  glen> http://trac.edgewall.org/browser/trunk/trac/htdocs/css/jquery-ui/jquery-ui.css#L229
13:23:48  glen> is it some kind of clever IE hack, or just jquery-ui themeroller magic quotes thing extending \ to \\ with each "save" (originally expanded from ' -> \') ? and
                nobody noticed it?
13:34:20  osimons> glen: the jquery-ui module is added to trac as-is, you question is likely better asked in #jquery
14:27:13  glen> osimons: nope. it's "customized" version, based on input params "you" provided
14:27:26  glen> and the input already contains dozens of %5C (urlencoded \)
14:27:40  glen> the expansion of \ may be fixed, but trac provides it's own
Day changed to 06 veebr 2013

[Christian Boos]

Ha! I noticed those and wondered… Glad to see they're not actually expected to be there…

[Christian Boos]

And I don't think the \ should be present in the first place:

.ui-widget {
        font-family: Verdana,Arial,'Bitstream Vera Sans',Helvetica,sans-serif;
        font-size: 13px;
}

Seems to be valid CSS.

[anonymous]

Looks like this was indeed a ​jQueryUI theme roller bug.

[Elan Ruusamäe <glen@…>]

cboos: that's what i'm saying, the backslash is there due magic quotes not stripped properly. common mistake in PHP "programming"

[Christian Boos]

Fixed in r11685. Thanks!