Edgewall Software
Modify

Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#11059 closed defect (fixed)

jquery ui css has overescaped backslashes

Reported by: Elan Ruusamäe <glen@…> Owned by: Christian Boos
Priority: normal Milestone: 1.0.2
Component: general Version: 1.0.1
Severity: minor Keywords: jqueryui css
Cc: Branch:
Release Notes:

Removed unnecessary repeated backslashes from jQuery UI CSS.

API Changes:
Internal Changes:

Description

jquery ui custom css has overescaped backslashes, due previous, or even current bug in the theme generator. most common case is that php magic quotes is enabled (in theme roller), and it's php code does not issue stripslashes properly when rendering the from with POST data again.

current state is that each time theme is regenerated, TRAC provides already overescaped url, imho it should be manually cleaned from URL and from Font name itself.

13:22:58  glen> hi. i noticed trac jquery-ui theme has excess of backslashes
13:23:01  glen> http://trac.edgewall.org/browser/trunk/trac/htdocs/css/jquery-ui/jquery-ui.css#L229
13:23:48  glen> is it some kind of clever IE hack, or just jquery-ui themeroller magic quotes thing extending \ to \\ with each "save" (originally expanded from ' -> \') ? and
                nobody noticed it?
13:34:20  osimons> glen: the jquery-ui module is added to trac as-is, you question is likely better asked in #jquery
14:27:13  glen> osimons: nope. it's "customized" version, based on input params "you" provided
14:27:26  glen> and the input already contains dozens of %5C (urlencoded \)
14:27:40  glen> the expansion of \ may be fixed, but trac provides it's own
Day changed to 06 veebr 2013

Attachments (0)

Change History (7)

comment:1 by Christian Boos, 8 years ago

Milestone: 1.0.2

Ha! I noticed those and wondered… Glad to see they're not actually expected to be there…

comment:2 by Christian Boos, 8 years ago

And I don't think the \ should be present in the first place:

.ui-widget {
        font-family: Verdana,Arial,'Bitstream Vera Sans',Helvetica,sans-serif;
        font-size: 13px;
}

Seems to be valid CSS.

comment:3 by anonymous, 8 years ago

Looks like this was indeed a jQueryUI theme roller bug.

comment:4 by Elan Ruusamäe <glen@…>, 8 years ago

cboos: that's what i'm saying, the backslash is there due magic quotes not stripped properly. common mistake in PHP "programming"

comment:5 by Christian Boos, 8 years ago

Keywords: jqueryui css added
Resolution: fixed
Severity: normalminor
Status: newclosed
Version: 1.0.1

Fixed in r11685. Thanks!

comment:6 by Ryan J Ollos <ryan.j.ollos@…>, 8 years ago

Owner: set to Christian Boos

comment:7 by Ryan J Ollos, 7 years ago

Release Notes: modified (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.