Edgewall Software
Modify

Opened 12 years ago

Closed 11 years ago

#11030 closed enhancement (fixed)

use 'border-radius' in the div environment and more.

Reported by: anonymous Owned by: Christian Boos
Priority: normal Milestone: 1.0.2
Component: wiki system Version:
Severity: normal Keywords: html
Cc: Branch:
Release Notes:
API Changes:

Added border-radius and border-*-*-radius to SAFE_CSS in trac.util.html.

Internal Changes:

Description (last modified by Ryan J Ollos)

Could you add 'border-radius' to the SAFE_CSS 'frozenset' in trac/util/html.py?

Attachments (0)

Change History (8)

comment:1 by Christian Boos, 12 years ago

Component: generalwiki system
Keywords: html added
Milestone: 1.0.2
Owner: set to Christian Boos
Status: newassigned

Sure.

comment:2 by Ryan J Ollos, 11 years ago

Description: modified (diff)

comment:3 by Ryan J Ollos, 11 years ago

It seems like a pretty simple change, though I'm not entirely sure what "safe css" means. Should I just go ahead and add it to the set?

comment:4 by Remy Blank, 11 years ago

It means the CSS attribute can't be used as an attack vector (e.g. XSS, or overlay a clickable with a transparent one that does something else), and therefore doesn't need to be filtered from user-supplied HTML.

Yes, you can simply add it to the set.

comment:5 by Ryan J Ollos, 11 years ago

API Changes: modified (diff)
Resolution: fixed
Status: assignedclosed

Thanks. Committed to 1.0-stable in [12062] and merged to trunk in [12063].

comment:6 by Jun Omae, 11 years ago

Oh, I think that we should add also border-*-*-radius, e.g. border-top-left-radius. See Property Index - CSS Backgrounds and Borders Module Level 3.

comment:7 by Ryan J Ollos, 11 years ago

Resolution: fixed
Status: closedreopened

Okay, I'll add those as well :)

comment:8 by Ryan J Ollos, 11 years ago

API Changes: modified (diff)
Resolution: fixed
Status: reopenedclosed

Committed to 1.0-stable in [12064] and merged to trunk in [12065].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.