regression in format_date, etc.

[Christian Boos]

Looks like in r11445 the support for format='iso8601' in format_date and format_time is gone. We probably didn't have unit tests for that feature, but it was documented (​format_datetime).

I suppose something like this would do:

datefmt.py

@@ -196 +196 @@
 
 def _format_datetime(t, format, tzinfo, locale, hint):
     t = to_datetime(t, tzinfo or localtz)
 
+    if format == 'iso8601':
+        return _format_datetime_without_babel(t, format + hint)
+
     if locale == 'iso8601':
         format = _ISO8601_FORMATS[hint].get(format, format)

(+ some tests, of course)

[Jun Omae]

Oh…. The unit tests for format_datetime with format=iso8601 are in branches/1.0-stable/trac/util/tests/datefmt.py#L526​, but the tests for format_date and format_time are missing.

I'll commit the patch with tests later. Thanks!

$ PYTHONPATH=$PWD ~/venv/py25/bin/python
Python 2.5.6 (r256:88840, Feb 29 2012, 04:03:24)
[GCC 4.1.2 20080704 (Red Hat 4.1.2-51)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> from trac.util.datefmt import to_datetime, format_datetime, format_date, format_time
>>> dt = to_datetime(None)
>>> format_datetime(dt, format='iso8601')      # ok
u'2013-01-10T01:12:23+09:00'
>>> format_datetime(dt, format='iso8601date')  # ok
u'2013-01-10'
>>> format_datetime(dt, format='iso8601time')  # ok
u'01:12:23+09:00'
>>> format_date(dt, format='iso8601')          # expected '2013-01-10'
u'2013-01-10T01:12:23+09:00'
>>> format_time(dt, format='iso8601')          # expected '01:12:23+09:00'
u'2013-01-10T01:12:23+09:00'
>>>

[Christian Boos]

Great! Thank you Jun.

[Jun Omae]

The patch with unit tests is committed in [11510-11511]. Thanks.