Add tri-state behavior to the batch modify group togglers

[Ryan J Ollos <ryan.j.ollos@…>]

The attached patch causes the group toggler to change state when the grouped toggle checkboxes are selected. The group toggler code is also refactored.

Mentioned in comment:13:ticket:9609.

[Ryan J Ollos <ryan.j.ollos@…>]

Patch against r11483 of the trunk.

[Ryan J Ollos <ryan.j.ollos@…>]

Two comments related to this patch:

• I'm not entirely confident about my use of ​closest rather than ​parents. cboos suggested I use closest in comment:11:ticket:9609, but I don't have the use cases entirely sorted out in my mind.
• The jQuery documentation for ​prop suggests that method should be used rather than ​attr for changing the checked property, which motivated the changes attr("checked", this.checked) → prop("checked", this.checked).

[Remy Blank]

closest is fine, however you need to match both <thead> and <tbody>, as only the first group is a <thead>. I have fixed it here already. The use of prop is good.

[Remy Blank]

Slightly fixed patch applied in [11505], together with a small optimization in the same code in the plugin admin panel. (There must be a way to combine both implementations into a generically-usable function, but it wasn't immediately obvious, so I left it at that.)

[Ryan J Ollos <ryan.j.ollos@…>]

Replying to rblank:

(There must be a way to combine both implementations into a generically-usable function, but it wasn't immediately obvious, so I left it at that.)

It hasn't been obvious to me how to accomplish this either, but I've had it on my todo list so that the select all functionality could also easily be added to some of the admin panels that have tables. I can look into make this change as part of #10994.

[Christian Boos]

Note that this tri-state behavior would probably be very useful for the repository filter in the timeline… I was 99% sure we had a ticket about the current behavior of this filter being somewhat confusing, but I can't find it anymore (#8758 is only the original enhancement request ticket).

[Ethan Jucovy <ethan.jucovy@…>]

Replying to cboos:

Note that this tri-state behavior would probably be very useful for the repository filter in the timeline… I was 99% sure we had a ticket about the current behavior of this filter being somewhat confusing, but I can't find it anymore (#8758 is only the original enhancement request ticket).

Yes, there is a ticket about that — #10144

[Christian Boos]

Replying to Ethan Jucovy <ethan.jucovy@…>:

Yes, there is a ticket about that — #10144

Thanks a lot, yes that was it.

[Christian Boos]

Ryan, would you mind updating the Release Notes: and API Changes: fields (as appropriate) of the tickets you contributed?.

[Ryan J Ollos <ryan.j.ollos@…>]

Sure, I will do that later this evening.