Edgewall Software

Opened 10 years ago

Closed 10 years ago

Last modified 9 years ago

#10967 closed defect (fixed)

Show *.po header in page footer if [project] footer is empty

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Milestone: 0.12.5
Component: i18n Version: 0.12-stable
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Fixed showing wrongly *.po header if [project] footer is empty

API Changes:
Internal Changes:


If [project] footer in trac.ini is empty, Trac wrongly shows *.po header in the page footer.

Real world examples → google:'"Powered by Trac" "Project-Id-Version: Trac" "Report-Msgid-Bugs-To: trac-dev@googlegroups.com POT-Creation-Date"'

  • trac/web/chrome.py

    709709            'admin_href': admin_href,
    710710            'admin_trac_url': self.env.project_admin_trac_url,
    711711        }
     712        footer = self.env.project_footer
    712713        d['chrome'] = {
    713             'footer': Markup(translation.gettext(self.env.project_footer))
     714            'footer': Markup(footer and translation.gettext(footer))
    714715        }
    715716        if req:
    716717            d['chrome'].update(req.chrome)

I'll commit it right away.

Attachments (0)

Change History (2)

comment:1 by Jun Omae, 10 years ago

Release Notes: modified (diff)
Status: newclosed

Committed in [11473-11475].

comment:2 by Remy Blank, 9 years ago

Resolution: fixed

Weird, this ticket had no resolution.

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jun Omae to the specified user.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.