#10923 closed defect (fixed)
Initial syntax highlighting sample fails in pygments preferences for browsers other than firefox
Reported by: | Owned by: | Peter Koželj | |
---|---|---|---|
Priority: | normal | Milestone: | 0.12.5 |
Component: | rendering | Version: | |
Severity: | normal | Keywords: | webkit |
Cc: | Branch: | ||
Release Notes: |
Fix initial activation of default style in Pygments' pref panel on WebKit browsers. |
||
API Changes: | |||
Internal Changes: |
Description
With Chrome 22 on Debian 6 with the latest trunk (r11412), syntax highlighting of the sample in the Syntax Highlighting preferences view in not effective until the Style is changed. Here is an example:
The attached patch duplicates the patch by Peter Koželj of the Bloodhound development team.
Attachments (2)
Change History (10)
by , 12 years ago
Attachment: | ExampleOfSyntaxHighlightingFailure.png added |
---|
by , 12 years ago
Attachment: | t10356-r11412-1.patch added |
---|
comment:1 by , 12 years ago
Thanks! I think that this was issue for nearly as long as the feature itself, and nobody cared to fix it so far…
Could you please add a reference to the original ticket, if there is one?
follow-ups: 4 6 comment:3 by , 12 years ago
[OT] As the "b" shortcuts are quite popular (#B1, #bn1, #bl1), it was not obvious which one to choose for BloodHound: bh or bd? Pick one or both ;-)
Back to the issue… this webkit bug is quite puzzling: I tried some other approaches, like not leaving the disabled
property alone for the style selected by default, in hope this wouldn't trigger the problem (see this comment in particular), but that doesn't work. What I've observed is that:
- by not touching at any
.disabled
property, all the stylesheets are active (the snippet gets some syntax highlighting) - by setting one
.disabled
property totrue
, none of these stylesheets are active (though when queried later, their.disabled
property is indeedfalse
for all but the one set totrue
)
So… it would need some serious debugging at the C++ level, if someone's interested in finding out what's really happening.
But the proposed workaround works perfectly, so I'll also content me with that ;-)
follow-up: 5 comment:4 by , 12 years ago
Replying to cboos:
[OT] As the "b" shortcuts are quite popular (#B1, #bn1, #bl1), it was not obvious which one to choose for BloodHound: bh or bd? Pick one or both ;-)
The consensus seems to be that the bh
InterTrac prefix would be most useful.
comment:5 by , 12 years ago
Replying to Ryan J Ollos <ryan.j.ollos@…>:
The consensus seems to be that the
bh
InterTrac prefix would be most useful.
… and it rhymes with TH ;-)
Looks like it was already there anyway ([BH:]).
comment:6 by , 12 years ago
Keywords: | webkit added |
---|---|
Milestone: | → 0.12.5 |
Release Notes: | modified (diff) |
Resolution: | → fixed |
Status: | new → closed |
But the proposed workaround works perfectly, so I'll also content me with that ;-)
Applied in r11423, thanks!
comment:7 by , 12 years ago
Owner: | set to |
---|
comment:8 by , 12 years ago
(and sorry for messing up the name in the commit itself, I forgot to use --encoding utf-8
)
Patch against r11412.