Modify ↓
#10899 closed defect (duplicate)
GitPlugin: PyGIT.get_historian() fails with OSError: [Errno 3]
Reported by: | Owned by: | ||
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | plugin/git | Version: | 1.0 |
Severity: | normal | Keywords: | |
Cc: | Branch: | ||
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
In the code:
p[0].stdout.close() p[0].terminate() p[0].wait()
The terminate is dying with OSError.
Attachments (0)
Change History (3)
comment:1 by , 12 years ago
comment:2 by , 12 years ago
diff —git a/tracext/git/PyGIT.py b/tracext/git/PyGIT.py index 8e8f7d3..02bad05 100644 —- a/tracext/git/PyGIT.py +++ b/tracext/git/PyGIT.py @@ -755,8 +755,9 @@ class Storage(object):
return gen.next()
yield historian
- if p:
+ if p[0].poll() is None:
p[0].stdout.close()
+ if p[0].poll() is None:
Version 0, edited 12 years ago by (next)
Note:
See TracTickets
for help on using tickets.
The problem seems to be if you have a version of Git for which closing stdout exits the process.
The solution is: