GitPlugin: PyGIT.get_historian() fails with OSError: [Errno 3]

[mresnick@…]

In the code:

        p[0].stdout.close()
        p[0].terminate()
        p[0].wait()

The terminate is dying with OSError.

[anonymous]

The problem seems to be if you have a version of Git for which closing stdout exits the process.

The solution is:

        if p[0].poll() is None:
            p[0].stdout.close()
        if p[0].poll() is None:
            p[0].terminate()
            p[0].wait()

[mresnick@…]

tracext/git/PyGIT.py

@@ -755 +755 @@
                 return gen.next()
         yield historian
 
-        if p:
+        if p[0].poll() is None:
             p[0].stdout.close()
+        if p[0].poll() is None:
             p[0].terminate()
             p[0].wait()

[Jun Omae]

duplicate of #10958.