Modify ↓
#10860 closed enhancement (fixed)
Display more readable `max_preview_size` when attachment can't be rendered due to exceeding allowed size
| Reported by: | Owned by: | ||
|---|---|---|---|
| Priority: | lowest | Milestone: | 1.1.1 |
| Component: | attachment | Version: | 1.1.1dev |
| Severity: | trivial | Keywords: | |
| Cc: | Branch: | ||
| Release Notes: |
File size is pretty-printed when the file can't be previewed or uploaded due to exceeding a size limit. |
||
| API Changes: | |||
| Internal Changes: | |||
Description
When an attachment can't be rendered because it is too large for the particular Trac configuration, we see:
The attached one-line patch changes this to the more readable:
Attachments (4)
Change History (9)
by , 12 years ago
| Attachment: | BeforePatch.png added |
|---|
by , 12 years ago
| Attachment: | AfterPatch.png added |
|---|
by , 12 years ago
| Attachment: | t10860-r11333-1.patch added |
|---|
follow-up: 2 comment:1 by , 12 years ago
Nice!
Nitpick: KB==KiloBytes, so KB bytes… KiloBytes bytes!
comment:2 by , 12 years ago
Replying to cboos:
Nice!
Nitpick: KB==KiloBytes, so KB bytes… KiloBytes bytes!
Hah, I guess I should have actually read the images I posted ;) The new patch addresses that, and a few other instances of bytes → pretty_print(…).
comment:3 by , 12 years ago
| Milestone: | → 1.1.1 |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Applied in r11354, thanks!
comment:4 by , 12 years ago
| Owner: | set to |
|---|
comment:5 by , 12 years ago
| Release Notes: | modified (diff) |
|---|
Note:
See TracTickets
for help on using tickets.
Patch against r11333 of the trunk.