Edgewall Software
Modify

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#10860 closed enhancement (fixed)

Display more readable `max_preview_size` when attachment can't be rendered due to exceeding allowed size

Reported by: Ryan J Ollos <ryan.j.ollos@…> Owned by: Ryan J Ollos <ryan.j.ollos@…>
Priority: lowest Milestone: 1.1.1
Component: attachment Version: 1.1.1dev
Severity: trivial Keywords:
Cc: Branch:
Release Notes:

File size is pretty-printed when the file can't be previewed or uploaded due to exceeding a size limit.

API Changes:
Internal Changes:

Description

When an attachment can't be rendered because it is too large for the particular Trac configuration, we see:

The attached one-line patch changes this to the more readable:

Attachments (4)

BeforePatch.png (13.3 KB ) - added by Ryan J Ollos <ryan.j.ollos@…> 9 years ago.
AfterPatch.png (13.6 KB ) - added by Ryan J Ollos <ryan.j.ollos@…> 9 years ago.
t10860-r11333-1.patch (811 bytes ) - added by Ryan J Ollos <ryan.j.ollos@…> 9 years ago.
Patch against r11333 of the trunk.
t10860-r11333-2.patch (2.2 KB ) - added by Ryan J Ollos <ryan.j.ollos@…> 9 years ago.
Patch against r11333 of the trunk.

Download all attachments as: .zip

Change History (9)

by Ryan J Ollos <ryan.j.ollos@…>, 9 years ago

Attachment: BeforePatch.png added

by Ryan J Ollos <ryan.j.ollos@…>, 9 years ago

Attachment: AfterPatch.png added

by Ryan J Ollos <ryan.j.ollos@…>, 9 years ago

Attachment: t10860-r11333-1.patch added

Patch against r11333 of the trunk.

comment:1 by Christian Boos, 9 years ago

Nice!

Nitpick: KB==KiloBytes, so KB bytes… KiloBytes bytes!

in reply to:  1 comment:2 by Ryan J Ollos <ryan.j.ollos@…>, 9 years ago

Replying to cboos:

Nice!

Nitpick: KB==KiloBytes, so KB bytes… KiloBytes bytes!

Hah, I guess I should have actually read the images I posted ;) The new patch addresses that, and a few other instances of bytes → pretty_print(…).

by Ryan J Ollos <ryan.j.ollos@…>, 9 years ago

Attachment: t10860-r11333-2.patch added

Patch against r11333 of the trunk.

comment:3 by Christian Boos, 9 years ago

Milestone: 1.1.1
Resolution: fixed
Status: newclosed

Applied in r11354, thanks!

comment:4 by Christian Boos, 9 years ago

Owner: set to Ryan J Ollos <ryan.j.ollos@…>

comment:5 by Ryan J Ollos <ryan.j.ollos@…>, 9 years ago

Release Notes: modified (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos <ryan.j.ollos@…>.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos <ryan.j.ollos@…> to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.