When attaching a file that contains colons, only part after colon is displayed

[info@…]

I have files created by a script that contain a timestamp in their filename. E.g.

2012-09-11_15:36:40-test.tbz2

When I add this to a wiki entry as an attachment, it gets renamed to

40-test.tbz2

which looks like some internal quoting glitch to me.

[Christian Boos]

testing…

[Christian Boos]

Reproduced. If the fix is not too disruptive, it could apply to milestone:0.12.5 as well.

[Jun Omae]

The issue is caused by replacing a colon character with a slash character at branches/0.12-stable/trac/attachment.py@10837#L660​.

That code is probably for Internet Explorer which uploads with full path as uploading file, however, I think we can remove that code.

And, we should use posixpath.basename instead of os.path.basename to determine the base name of the uploaded file. os.path.basename on Windows separates with slash, backslash and colon characters.

[9d8c6e5a/jomae.git]

[Christian Boos]

I confirm that the proposed change fixes the issue, and that besides upload still works well from IE.

However I see now that we'll get a similar issue with \ in the filename. Like for ":", we might have those in filenames on Unix.

[Jun Omae]

Right. However we should replace backslashes when a browser sends Windows full path as the uploaded file. It depends on the security settings in Internet Explorer.

trac/attachment.py

@@ -658 +658 @@
         # Files uploaded from OS X might be in NFD.
         filename = unicodedata.normalize('NFC', unicode(upload.filename,
                                                         'utf-8'))
-        filename = filename.strip().replace('\\', '/')
+        filename = filename.strip()
+        # Replace backslashes with slashes if filename is Windows full path
+        if filename.startswith('\\') or re.match(r'[A-Za-z]:\\', filename):
+            filename = filename.replace('\\', '/')
         # We want basename to be delimited by only slashes on all platforms
         filename = posixpath.basename(filename)
         if not filename:

[Jun Omae]

[9d8c6e5a/jomae.git] is to keep colons and [39f4193b/jomae.git] is to keep backslashes (the patch in comment:4 with unit tests). I'll apply to 0.12-stable tonight.

[Christian Boos]

Fine by me!

The last problem with attachments containing a : in their name is that we can't link to them with the usual TracLinks syntax: e.g. attachment:the:filename:wiki:WikiStart won't work.

Given how rare accessing such filenames is, I'm not sure it's worth trying to "fix" that though, given one could always use the explicit URL [/attachment/wiki/WikiStart/A%3AFILE].

[Jun Omae]

Given how rare accessing such filenames is, I'm not sure it's worth trying to "fix" that though, given one could always use the explicit URL [/attachment/wiki/WikiStart/A%3AFILE].

Agreed. But if did, I think I would add attachment:"the:filename.txt" to TracLinks syntax….

The patches are applied in [11365-11367].