contrib/trac-svn-hook to support TRAC_PARENT_ENV

[Elan Ruusamäe <glen@…>]

this patch adds TRAC_PARENT_ENV support to browser:trunk/contrib/trac-svn-hook​

[Christian Boos]

Looks good!

… except that a TracEnvironment doesn't have a conf/VERSION file usually! (it's just <envdir>/VERSION).

Bonus points for supporting .tracignore​ glob patterns ;-)

[Elan Ruusamäe <glen@…>]

fixed VERSION path

[Elan Ruusamäe <glen@…>]

btw the comment in browser:trunk/trac/web/main.py@11236​ is a bit misleading, it says that it returns .* if file does not exist. first i thought it means everything as was thinking of regexp, but then trying to understand why it does not behave so (as with that pattern would exclude all trac envs, but it did not). perhaps add comment to it that it means "all hidden files" :)

so, my proposition for rewording:

def get_tracignore_patterns(env_parent_dir):
    """Return the list of patterns from env_parent_dir/.tracignore or
    a default pattern of `".*"` matching all hidden files if the file doesn't exist.
    """

[Elan Ruusamäe <glen@…>]

added .tracignore support! :)

[Elan Ruusamäe <glen@…>]

updated doc a bit with .gitignore

[Christian Boos]

Replying to Elan Ruusamäe <glen@…>:

btw the comment in browser:trunk/trac/web/main.py@11236​ is a bit misleading, it says that it returns .* if file does not exist. first i thought it means everything as was thinking of regexp, but then trying to understand why it does not behave so (as with that pattern would exclude all trac envs, but it did not). perhaps add comment to it that it means "all hidden files" :)

Yep, got mislead myself until I spotted the use of fnmatch in the code ;-)

so, my proposition for rewording:

def get_tracignore_patterns(env_parent_dir):
    """Return the list of patterns from env_parent_dir/.tracignore or
    a default pattern of `".*"` matching all hidden files if the file doesn't exist.
    """

Thanks! And saying "glob pattern" instead of just "pattern".

[Elan Ruusamäe <glen@…>]

i think it wouldn't hurt to describe it in human text what the default pattern matches. if reading diagonally could still interpret commonly seen .* pattern as "regex for match anything"…

[Elan Ruusamäe <glen@…>]

please commit in :)

[Christian Boos]

Right, forgot to set the milestone.

[Ryan J Ollos]

Moved ticket assigned to next-stable-1.0.x since maintenance of 1.0.x is coming to a close. Please move the ticket back if it's critical to fix on 1.0.x.

[Ryan J Ollos]

Milestone renamed