AttributeError raises at Storage.__del__ if invalid location as git repository

[Jun Omae]

When I configured with invalid location as git repository, tracd output the following to the console.

Exception AttributeError: "'Storage' object has no attribute '_Storage__cat_file_pipe_lock'" in <bound method Storage.__del__ of <tracopt.versioncontrol.git.PyGIT.Storage object at 0xb0d318c>> ignored

It would be good to move the instance variables initialization to intro of __init__.

tracopt/versioncontrol/git/PyGIT.py

@@ -357 +357 @@
 
         self.logger = log
 
+        self.commit_encoding = None
+
+        # caches
+        self.__rev_cache = None
+        self.__rev_cache_lock = Lock()
+
+        # cache the last 200 commit messages
+        self.__commit_msg_cache = SizedDict(200)
+        self.__commit_msg_lock = Lock()
+
+        self.__cat_file_pipe = None
+        self.__cat_file_pipe_lock = Lock()
+
         if git_fs_encoding is not None:
             # validate encoding name
             codecs.lookup(git_fs_encoding)
@@ -381 +394 @@
             raise GitError("GIT control files not found, maybe wrong "
                            "directory?")
 
-        self.logger.debug("PyGIT.Storage instance %d constructed" % id(self))
-
         self.repo = GitCore(git_dir, git_bin=git_bin)
 
-        self.commit_encoding = None
-
-        # caches
-        self.__rev_cache = None
-        self.__rev_cache_lock = Lock()
-
-        # cache the last 200 commit messages
-        self.__commit_msg_cache = SizedDict(200)
-        self.__commit_msg_lock = Lock()
-
-        self.__cat_file_pipe = None
-        self.__cat_file_pipe_lock = Lock()
+        self.logger.debug("PyGIT.Storage instance %d constructed" % id(self))
 
     def __del__(self):
         with self.__cat_file_pipe_lock:

[Christian Boos]

This indeed makes the Exception go away. Feel free to commit!

[Jun Omae]

Applied in [11217].