Workflow macro generates invalid colors

[Peter Suter]

When using the Workflow macro with more than five actions, invalid colors can be generated.

For example the above graph causes Firefox to log a warning Expected color but found '#3abb'. and use the same color twice.

The fix is simple:

trac/htdocs/js/workflow_graph.js

@@ -172 +172 @@
   };
 
   function hexColor(r, g, b) {
-    return '#' + 
-      Math.floor(r).toString(16) +
-      Math.floor(g).toString(16) +
-      Math.floor(b).toString(16);
+    r = (r < 16 ? '0' : '') + Math.floor(r).toString(16);
+    g = (g < 16 ? '0' : '') + Math.floor(g).toString(16);
+    b = (b < 16 ? '0' : '') + Math.floor(b).toString(16);
+    return String.concat('#', r, g, b);
   }
 
   function saturatedColor(r, g, b) {

[Remy Blank]

If you have the fix already, feel free to apply it to 1.0dev.

[Peter Suter]

OK, applied in [11196].

[Christian Boos]

Oops…

TypeError: Object function String() { [native code] } has no method 'concat' workflow_graph.js:178

[Christian Boos]

-  return String.concat('#', r, g, b); 
+  return '#'.concat(r, g, b);

Works in Chrome at least.

[Peter Suter]

Oops indeed! I'm not sure why I even switched away from +. (​Apparently it's faster too.) Backed that out in [11199].

Thanks for noticing!

[Peter Suter]

Hopefully that settles that. :)