CachedRepository doesn't cache non-latest changesets after caching latest changeset

[Jun Omae]

CachedRepository caches newer changesets than youngest_rev in metadata. In subversion, a committed changeset is always newer than the cached changesets and will be cached. However, in Git, a pushed change is not always newer and will not be cached….

Reproduce

1. Setup Trac 0.12-stable with git-plugin (or 1.0dev with tracopt.git)
2. Setup ​git://github.com/jun66j5/trac-git-cache.git

   jun66j5@gotanda:1672$ git log --all --oneline --graph
   * 9f5e555 [master] third
   | * 97cbb3c [dev] second
   |/
   * 57fa298 [master] first
   

3. Push master branch. 57fa298 and 9f5e555 will be cached.
4. Push dev branch. 97cbb3c will NOT be cached.

Workaournd

If the changeset is not cached at CachedRepository.sync_changeset(rev), creates revision and node_change records.

repos:jomae.git:ticket10759/creating-cache-on-sync/0.12

[Christian Boos]

This is somehow related to the changeset hook ticket #10730: we could probably try to detect all what's new since last time, starting from all the refs, but better do that proactively by using hooks and then update the cache when changes are pushed in (or "deleted").

Now about the proposed workaround, it looks OK but would probably benefit from a little refactoring (I'll follow-up on this).

[Christian Boos]

See repos:cboos.git:ticket10759/creating-cache-on-sync/0.12

[Christian Boos]

Jun, did you have the chance to validate my follow-up?

[Christian Boos]

Also, it's a change on 0.12-stable, so is there a reason why you thought that to be too risky for 0.12.4? I'd be OK with 0.12.4, provided a few more testing.

[Jun Omae]

Jun, did you have the chance to validate my follow-up?

Looks good, Thanks.

Also, it's a change on 0.12-stable, so is there a reason why you thought that to be too risky for 0.12.4? I'd be OK with 0.12.4, provided a few more testing.

No reason, however, I think that there is a little risk.

I want to push to 0.12.4 and I'll provide unit tests for the changes to avoid the risk.

[Christian Boos]

Tested [f83d4173/jomae.git] and [0f7cb3b5/jomae.git]. Works fine!

[Jun Omae]

Applied in [11159] and [11160]. Thanks for the follow-ups, Christian!