Edgewall Software
Modify

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#10756 closed enhancement (fixed)

include date picker into admin panel and timeline

Reported by: framay <franz.mayer@…> Owned by: Ryan J Ollos <ryano@…>
Priority: normal Milestone: 1.0
Component: general Version: 0.13dev
Severity: normal Keywords: bitesized patch
Cc: ryano@… Branch:
Release Notes:

Added date picker for date fields in admin panels and the timeline.

API Changes:

Description

When adding / changing milestone via "Roadmap" date picker is working fine (see ticket #10245).

It would be nice if the date picker would also be included when adding / changing milestones via admin panel.

Another place where a date picker would be useful is in Timeline view.

Attachments (1)

t10756-r11100-1.patch (5.4 KB ) - added by Ryan J Ollos <ryano@…> 7 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 by Ryan J Ollos <ryano@…>, 7 years ago

Cc: ryano@… added

On the Admin page it could be used on the Versions panel as well. We've previously used the th:DateFieldPlugin for this.

comment:2 by Remy Blank, 7 years ago

Keywords: bitesized added
Milestone: next-major-releases

comment:3 by Ryan J Ollos <ryano@…>, 7 years ago

The implementation seems fairly straightforward since Pete did all the real work in #10245, [10992:10993].

Here is a patch that adds a date or datetime picker to the following locations:

  • Admin panel: Version release date (datetime picker)
  • Admin panel: Milestone due date and completed date (datetime picker)
  • Timeline: filter from date (date picker)
  • Custom query: Created by constraint (date picker)

I'm not confident that I implemented the date picker for the Custom query Created by constraint correctly. The way it is implemented, Chrome(self.env).add_jquery_ui(req) must be called together with add_script(req, 'common/js/query.js').

I'm hoping to get some feedback on the patch.

by Ryan J Ollos <ryano@…>, 7 years ago

Attachment: t10756-r11100-1.patch added

comment:4 by Ryan J Ollos <ryano@…>, 7 years ago

Related issue: th:DateFieldPlugin will be modified in th:#10107 to utilize the jQuery UI date picker and datetime picker that ships with Trac 1.0. The plugin would be obsolete though if the Trac core had a way to add a date or datetime picker to a custom field.

in reply to:  4 comment:5 by Remy Blank, 7 years ago

Keywords: patch added
Milestone: next-major-releasesnext-dev-1.1.x

Replying to Ryan J Ollos <ryano@…>:

The plugin would be obsolete though if the Trac core had a way to add a date or datetime picker to a custom field.

This should be done in the context of #1942 (and maybe already is, I don't remember).

in reply to:  3 comment:6 by Peter Suter, 7 years ago

Replying to rblank:

add a date or datetime picker to a custom field.

This should be done in the context of #1942 (and maybe already is, I don't remember).

Yes, comment:72:ticket:1942 mentions datetimepicker.patch, which adds date pickers for all custom date fields on the query and ticket pages.

Replying to Ryan J Ollos <ryano@…>:

I'm not confident that I implemented the date picker for the Custom query Created by constraint correctly. The way it is implemented, Chrome(self.env).add_jquery_ui(req) must be called together with add_script(req, 'common/js/query.js').

I'm hoping to get some feedback on the patch.

Looks good to me. In that custom field datetimepicker.patch I used the same approach.

comment:7 by Peter Suter, 7 years ago

Milestone: next-dev-1.1.x1.0
Owner: set to Ryan J Ollos <ryano@…>

Reviewed and tested. I couldn't find anything wrong with this patch. It nicely completes the effort started in #10245. Committed in [11104].

comment:8 by Peter Suter, 7 years ago

Resolution: fixed
Status: newclosed

comment:9 by Christian Boos, 7 years ago

Release Notes: modified (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos <ryano@…>.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Ryan J Ollos <ryano@…> to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.