Zip Download in TracMercurial is wrong

[anonymous]

A downloaded zip archive from the browser includes only the files which were modified in the current changeset and not all files representing the current changeset.

[anonymous]

I too ran into this problem. I discovered you can work around this by diffing current revision with revision 0 and then downloading changeset though it seems like this should be unnecessary

[Christian Boos]

I'll take a look.

[Christian Boos]

Verified. Would be nice to fix this so that we can enable the download for the plugin itself.

[huang]

same thing happen for git repo I don't know how about svn, does it only work on svn? It seems in the implementation, it implemented /trunk, /branches/*,/tags/* doesn't seems included the git file structures

[schlamar]

Here is the issue. The SVN backend is ignoring old_rev if new_node.isdir: ​http://trac.edgewall.org/browser/trunk/tracopt/versioncontrol/svn/svn_fs.py?rev=11493#L672

[schlamar]

Placing old_node = self.get_node(old_path, 0) at this ​line solves this issue.

However, there might be a better way because it seems really slow.

[schlamar]

Replying to huang:

same thing happen for git repo I don't know how about svn, does it only work on svn?

Yes

It seems in the implementation, it implemented /trunk, /branches/*,/tags/* doesn't seems included the git file structures

Just set downloadable_paths = * in trac.ini if using git/hg.

[schlamar]

Replying to schlamar:

Here is the issue. The SVN backend is ignoring old_rev if new_node.isdir: ​http://trac.edgewall.org/browser/trunk/tracopt/versioncontrol/svn/svn_fs.py?rev=11493#L672

Ah, not really… :-) The difference is actually old_path=%2F. If this is in the request, the SVN backend will download every file which is present in the selected changeset. If not, it will download only the files which were changed in the selected changeset.

See ​http://trac.edgewall.org/changeset/11711/?format=zip vs. ​http://trac.edgewall.org/changeset/11711/trunk?old_path=%2F&format=zip.

Here is the deal:

SVN is triggering the "special case for download" while hg is not, see

• ​http://trac.edgewall.org/browser/trunk/trac/versioncontrol/web_ui/changeset.py?rev=11711#L343

[schlamar]

Ahh, normalize_path is transforming '/' to an empty string which triggers then the case "revert to Changeset" in the next few lines:

​http://trac.edgewall.org/browser/trunk/trac/versioncontrol/web_ui/changeset.py?rev=11711#L258

[schlamar]

IMO triggering the "special case for download" if old_path == '/' was a bad design decision back in #238. I would introduce a special request argument like download=1 to trigger this case.

[schlamar <info@…>]

Changed the component as this should be fixed in Trac itself.

[Christian Boos]

If this is only about the "download .zip from TracBrowser" feature, this should be fixed now by the changes related to #8919.

There are still a few glitches for downloading .zip corresponding to changesets.

[schlamar <info@…>]

Yes, works now in 1.0.2dev.