Workflow action with non-ascii letters fails to change owner properly

[ebersac@…]

Hi,

Consider the two workflow actions below :

[ticket-workflow]
reassign = * -> *
reassign.operations = set_owner,leave_status
reassign.set_owner = client,po,team

todo = * -> todo
todo.operations = set_owner
todo.set_owner = client,po,team

If i set the owner with reassign action, it works well, as expected.

If i use the toto action, the owner is set to client,po,team literally, even if i select properly client.

Trac should set the status to todo and the owner to the one selected.

Can you confirm this ?

Regards, Étienne

[anonymous]

Hi,

Actually, the bug occurs when the action contains non ascii letter.

[ticket-workflow]
réassigner = * -> *
réassigner.operations = set_owner,leave_status
réassigner.set_owner = client,po,team

todo = * -> todo
todo.operations = set_owner
todo.set_owner = client,po,team

The set_owner operation from réassigner action will set owner to client,po,team.

Regards, Étienne

[Remy Blank]

You shouldn't use non-ASCII characters in workflow option names. Instead, you should set the .name option to localize the action. So in this case:

[ticket-workflow]
reassigner = * -> *
reassigner.name = réassigner
reassigner.operations = set_owner,leave_status
reassigner.set_owner = client,po,team

Does everything work fine with ASCII-only option names?

[anonymous]

Thanks for the answer.

Yep, i used the .name field, and it works properly. Thanks.

Would be nice if trac complains or ignore actions with non-ASCII letters. That's strange for a behaviour, to assign owner to all items !

Would a patch to prevent wrong action name be welcome ?

Regards, Étienne

[Remy Blank]

Replying to anonymous:

Would a patch to prevent wrong action name be welcome ?

Sure, patches are always welcome. Either log a warning when non-ASCII characters appear in action keys, or fix the workflow code so that it works correctly with such keys.

[Ryan J Ollos]

Tested with 1.2-stable and could not reproduce using the configuration in comment:1. I guess it's been fixed by now.