Rendered ticket action hints don't end with a fullstop
|Reported by:||Owned by:||Christian Boos|
Add a trailing period to the ticket action hint rendered in the workflow Action box, in the case that the hint is not empty.
The default configuration of Trac trunk renders the hints for a ticket action without a trailing fullstop i.e.
The resolution will be set. Next status will be 'closed'
The resolution will be set. Next status will be 'closed'.
- ITicketActionController.render_ticket_action_control() documents a single hint should be returned for the action
- [ConfigurableTicketWorkflow.render_ticket_action_control() source:trunk/trac/ticket/default_workflow.py#L329] joins it's multiple hints into one string by performing
- [Ticket.html source:trunk/trac/ticket/templates/ticket.html#L316] combines multiple hints (presumably in case more that one controller provides an action) by rendering each in a <span>
Ideally the displayed hint(s) would have a fullstop, since they're complete sentences. However th:XmlRpcPlugin currently joins the hints from multiple ITicketActionController by performing
". ".join(hints) + '.' - so having ConfigurableTicketWorkflow return "The resolution will be set. Next status will be 'closed'." would result in XmlRpcPlugin rendering a double fullstop.
Change History (10)
comment:4 by , 8 years ago
|Milestone:||next-stable-1.0.x → 1.0.1|
|Status:||new → closed|