#10625 closed defect (fixed)
"Comments only" checkbox removes attribute changes in comment preview
| Reported by: | Remy Blank | Owned by: | Peter Suter |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.0 |
| Component: | ticket system | Version: | 0.13dev |
| Severity: | minor | Keywords: | |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
The "Comments only" checkbox in tickets toggles the visibility of attribute changes in the change history. Currently, it also toggles the attributes in the comment preview, which makes it difficult to see the changed fields.
The attribute changes in the comment preview should always be visible.
And while we're at it, there's currently an error in the JavaScript that prevents the automatic preview from working when creating a new ticket. FireBug shows the following error in the console:
comments_prefs is not defined else if (comment_prefs.comments_order == 'threaded')
Attachments (2)
Change History (6)
by , 12 years ago
| Attachment: | t10625-commentsonly-leavepreview.patch added |
|---|
by , 12 years ago
| Attachment: | t10625-threadedcomments-dropscriptfromnewticketpage.patch added |
|---|
Drop threaded_comments.js script from new ticket page
comment:1 by , 12 years ago
The first patch above uses a more specific selector, so the comment preview is not affected anymore.
The second drops the threaded_comments.js script from the New ticket page, avoiding the comments_prefs is not defined error.
OK?
comment:3 by , 12 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:4 by , 12 years ago
| Severity: | normal → minor |
|---|
Leave comment preview alone