Opened 13 years ago
Closed 11 years ago
#10622 closed defect (fixed)
Diff viewer renders each line with an extra space character at the end
Reported by: | Owned by: | Ryan J Ollos | |
---|---|---|---|
Priority: | low | Milestone: | 1.0.2 |
Component: | rendering | Version: | |
Severity: | normal | Keywords: | bitesized |
Cc: | Branch: | ||
Release Notes: |
Removed trailing whitespace character from rendered diffs. |
||
API Changes: | |||
Internal Changes: |
Description
The unified view of a diff adds an additional space character at the end of each source line. e.g. for [11007] the markup for the deleted line is
<th>5188</th><th>5188</th><td class="l"><span>msgid "Blame"</span> </td>
If the rendered line of diff is copy/pasted from the browser the space is copied also, introducing whitespace that wasn't in the original files
Attachments (0)
Change History (5)
comment:1 by , 13 years ago
Keywords: | bitesized added |
---|---|
Milestone: | → next-minor-0.12.x |
comment:2 by , 12 years ago
It looks like it will be simple enough to remove the  
s from the template, here being one such place, and doing so doesn't seem to blatantly break anything, but I wonder why they were there in the first place. They've existed since the code was written in [3713#file1].
comment:3 by , 11 years ago
Milestone: | next-minor-0.12.x → 1.0.2 |
---|---|
Owner: | set to |
Status: | new → assigned |
comment:4 by , 11 years ago
Proposed change in log:rjollos.git:t10622 removes the nbsp
s from lines of code in the diff. I didn't change the nbsp
s in other content, such as th
s and the "skipped" separator between non-contiguous blocks of code.
comment:5 by , 11 years ago
Release Notes: | modified (diff) |
---|---|
Resolution: | → fixed |
Status: | assigned → closed |
This shouldn't be too difficult to fix.