Edgewall Software

Opened 10 years ago

Closed 8 years ago

#10622 closed defect (fixed)

Diff viewer renders each line with an extra space character at the end

Reported by: Alex Willmer <al.willmer@…> Owned by: Ryan J Ollos
Priority: low Milestone: 1.0.2
Component: rendering Version:
Severity: normal Keywords: bitesized
Cc: Branch:
Release Notes:

Removed trailing whitespace character from rendered diffs.

API Changes:
Internal Changes:


The unified view of a diff adds an additional space character at the end of each source line. e.g. for [11007] the markup for the deleted line is

<th>5188</th><th>5188</th><td class="l"><span>msgid "Blame"</span> </td>

If the rendered line of diff is copy/pasted from the browser the space is copied also, introducing whitespace that wasn't in the original files

Attachments (0)

Change History (5)

comment:1 by Remy Blank, 10 years ago

Keywords: bitesized added
Milestone: next-minor-0.12.x

This shouldn't be too difficult to fix.

comment:2 by Ryan J Ollos <ryan.j.ollos@…>, 9 years ago

It looks like it will be simple enough to remove the &nbsps from the template, here being one such place, and doing so doesn't seem to blatantly break anything, but I wonder why they were there in the first place. They've existed since the code was written in [3713#file1].

comment:3 by Ryan J Ollos, 8 years ago

Milestone: next-minor-0.12.x1.0.2
Owner: set to Ryan J Ollos
Status: newassigned

comment:4 by Ryan J Ollos, 8 years ago

Proposed change in log:rjollos.git:t10622 removes the nbsps from lines of code in the diff. I didn't change the nbsps in other content, such as ths and the "skipped" separator between non-contiguous blocks of code.

comment:5 by Ryan J Ollos, 8 years ago

Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Committed to 1.0-stable in [12671] and merged to trunk in [12672].

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ryan J Ollos to the specified user.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.