ListOption seems to ignore/suppress 0

[chris.nelson.1022@…]

I'm trying to add a list of work days (days of the week) to TeamCalendar plugin. Near the top I do:

class TeamCalendar(Component):
    implements(INavigationContributor, IRequestHandler, IPermissionRequestor, 
               ITemplateProvider)

...
    # Default work week.
    work_days = ListOption('team-calendar',
                            'work_days',
                            [0, 1, 2, 3, 4],
                            doc="Lists days of week that are worked. " + \
                                "Defaults to none.  0 is Monday.")

and later

        self.env.log.debug('work_days: %s ' % self.work_days)

        timetable = {}
        current_date = from_date
        while current_date <= to_date:
            if current_date.weekday() in self.work_days:

The log does not show the 0, only 1..4. If I set the default to [99, 0, 1, 2, 3, 4], the log shows 99 but not 0 so it isn't the first element that's getting dropped.

[Jun Omae]

Reproduced. ListOption drops 0 (int) and 0.0 (float) from raw list as default value.

Workaround is to specify string as default value.

    work_days = ListOption('team-calendar',
                           'work_days',
                           '0, 1, 2, 3, 4',
                           doc="Lists days of week that are worked. " + \
                                "Defaults to none. 0 is Monday."

If did fix this…

trac/config.py

@@ -455 +455 @@
         else:
             items = list(value)
         if not keep_empty:
-            items = filter(None, items)
+            items = filter(lambda val: val or val is not None and \
+                                       not isinstance(val, basestring),
+                           items)
         return items
 
     def getpath(self, key, default=''):

trac/tests/config.py

@@ -172 +172 @@
                     config.getlist('b', 'option2', ['foo', 'bar', 'baz']))
         self.assertEquals(['foo', 'bar', 'baz'],
                     config.getlist('b', 'option2', 'foo, bar, baz'))
+        self.assertEquals([-1, 0, 1],
+                          config.getlist('c', 'int', [-1, 0, 1]))
+        self.assertEquals([-1.0, 0.0, 1.0],
+                          config.getlist('c', 'float', [-1.0, 0.0, 1.0]))
 
     def test_read_and_getlist_sep(self):
         self._write(['[a]', 'option = foo | bar | baz'])

[Christian Boos]

If we're not using filter(None, ), we could as well use a list comprehension here?

items = [v for v in items if v or v is not None etc.]

And for the test itself, in trunk we could use isinstance(v, numbers.Number) if we indeed switch to Python 2.6 as a base requirement.

[Jun Omae]

Replying to cboos:

If we're not using filter(None, ), we could as well use a list comprehension here?

items = [v for v in items if v or v is not None etc.]

Oh, yes. Thanks ;-)

trac/config.py

@@ -455 +455 @@
         else:
             items = list(value)
         if not keep_empty:
-            items = filter(None, items)
+            items = [v for v in items
+                       if v or isinstance(v, (int, long, float))]
         return items
 
     def getpath(self, key, default=''):

I'll apply later.

[Jun Omae]

Fixed in [11478-11479].