Changeset viewer breaks when a change has no author

[verbosus]

In the changeset viewer, if one tries to view a changeset and the author of that rev is anonymous or hasn't been set – marked in ‘svn log’ as ‘(no author)’ – Trac breaks with this error:-

setValue(name, value)() argument 2 must be string or read-only buffer, not None

Full Traceback:-

Traceback (most recent call last):
  File "/usr/lib/python2.2/site-packages/trac/trac.py", line 203, in main
    real_main()
  File "/usr/lib/python2.2/site-packages/trac/trac.py", line 155, in real_main
    module.run()
  File "/usr/lib/python2.2/site-packages/trac/Module.py", line 37, in run
    self.render()
  File "/usr/lib/python2.2/site-packages/trac/Changeset.py", line 222, in render
    self.cgi.hdf.setValue('changeset.author', changeset_info['author'])
TypeError: setValue(name, value)() argument 2 must be string or read-only buffer, not None

Viewing a revision where the author has been set works fine, though. A possible solution would be to allow the setValue() function to allow ‘None’ as its second value or to check the value of changeset_infoauthor before doing that.

Cheers,

—Antonio Cavedoni

[Jonas Borgström]

Thanks for the report, but it looks like this bug already got fixed by [197].

[Christian Boos]

(clearing report:35)