Counting of Ticket-Comments defect

[schliske@…]

Hello,

in our trac installation I see the error that the ticket comment after comment 79 gets again the number 3. All comments after that comment are increased from 3.

OS is CentOS 6.

Regards,

Erwin Schliske

[Remy Blank]

Yes, that was a bug in early 0.12.x releases. It happened after tickets were re-targeted due to closing a milestone. We have had a few instances here on t.e.o, and I have fixed them all by hand in the database (ugly, I know). I haven't been able to reproduce the issue with current 0.12-stable, despite trying very hard, so I assume this was fixed some time in 0.12-stable.

We should provide a small script in contrib to scan the database and fix any broken comment threads.

[marthein1@…]

Replying to rblank:

I haven't been able to reproduce the issue with current 0.12-stable, despite trying very hard, so I assume this was fixed some time in 0.12-stable.

It looks like #10681 shows a way to reproduce this problem. I would like to see it fixed, as it corrupts the database.

[marthein1@…]

One of my colleagues also looked at the problem and says:

I think this is caused by only using the time in the join here​. Referenced ticket comments have the same time as the changeset, so that causes problems. Can be fixed by adding the ticket number as join requirement.

Seems to be fixed in trunk, see here​.

Bug is fixed in r10630.

[Ryan J Ollos]

Moved ticket assigned to next-stable-1.0.x since maintenance of 1.0.x is coming to a close. Please move the ticket back if it's critical to fix on 1.0.x.

[Ryan J Ollos]

Milestone renamed