[PATCH] remove spurious CR characters in notification via sendmail

[d.love@…]

Part of the notification email sent via sendmail has spurious CRLF line endings which either show up for the recipient as literal CR characters (and maybe provoke a non-text/plain MIME type) or double-spaced lines. At least that's the case with Postfix on a GNU/Linux system, and I guess it's a general issue with sendmail programs.

I'm using this patch to fix it with 0.12.2; there doesn't seem to be any relevant change in the trunk. It's not obvious how to write an appropriate test.

[Remy Blank]

Thanks for the patch. I'll check that. The strange thing is, I tested the implementation with Potstfix on Linux as well, so I wonder how I could miss that.

[Remy Blank]

Construct notification message with '\n' instead of CRLF.

[Remy Blank]

I tested again, and I see no spurious CR characters here (Postfix 2.8.4 on Linux). sendmail seems to be resilient against CRLF.

But your patch is still correct. CRLF is required when talking to a SMTP server, but not with a local sendmail program. I have applied a slightly different patch in [10809], by using the same code as for ensuring the message has CRLF everywhere for SmtpMessageSender.

I wonder, however, why we construct the message with CRLF instead of '\n'. The result is a hybrid text where the headers are separated by '\n' and the body lines are separated by CRLF. As both email senders now convert the message to the correct EOL, we should generate the message with only '\n' line endings. See 10377-notification-eol-r10809.patch​. All tests pass.

Opinions?

[Remy Blank]

After discussion with cboos, applied the patch in [10810], together with a refactoring of the EOL-fixing code.