Opened 13 years ago
Closed 11 years ago
#10283 closed defect (fixed)
In ticket e-mail notifications order of custom fields is not used
Reported by: | Mitar | Owned by: | Jun Omae |
---|---|---|---|
Priority: | normal | Milestone: | 0.12.6 |
Component: | notification | Version: | 0.12.1 |
Severity: | normal | Keywords: | |
Cc: | mmitar@… | Branch: | |
Release Notes: |
Improved layout of fields in the ticket notification if the field is wrapped. |
||
API Changes: | |||
Internal Changes: |
Description
In ticket e-mail notifications order of custom fields is not used. Custom fields can be ordered by order
setting. But in table in e-mail notification this is not used. It seems.
I have such configuration:
[ticket-custom] blockedby = text blockedby.label = Blocked by blockedby.order = 6 blocking = text blocking.label = Blocking blocking.order = 5 deployment = select deployment.label = Deployment state deployment.options = |idea, wish|offer|initial contact|coordination|realization deployment.order = 1 deployment.value = effort = select effort.label = Effort effort.options = highest|high|normal|low|lowest effort.order = 7 effort.value = normal nodes = text nodes.label = Related nodes nodes.order = 3 privacy = checkbox privacy.label = Privacy sensitive privacy.order = 2 privacy.value = 0 sensitive = checkbox sensitive.label = Security sensitive sensitive.order = 4 sensitive.value = 0
But table in notification looks like this:
-------------------------------------------------+------------------------- Reporter: XXXXX | Owner: Status: closed | Musti Component: XXXXXXXXXXXXXXXXXXXXXXXXXX | Priority: Keywords: | normal Privacy sensitive: 0 | Resolution: Security sensitive: 0 | fixed Blocked by: | Deployment state: | Related nodes: | XXXXXXXXXX | Blocking: | Effort: | normal -------------------------------------------------+-------------------------
When on site the order is: priority, component, keywords, cc, deployment state, privacy sensitive, related nodes, security sensitive, blocking, blocked by, effort, owner. Especially component is on the right, here is on the left.
Attachments (0)
Change History (7)
follow-up: 3 comment:1 by , 12 years ago
Resolution: | → worksforme |
---|---|
Status: | new → closed |
comment:2 by , 12 years ago
Still, layout should be the same, no? It is really not intuitive if things are different on the web and in the e-mail.
comment:3 by , 12 years ago
Replying to psuter:
(Assuming this order:
1. 2. 3. 4. 5. 6. ...and that fields may be pushed down by word wrapping.)
Right. The issue depends wrapping ticket properties, not order
settings of custom fields.
In [64f56357/jomae.git], improved the formatting with the wrapped properties.
comment:4 by , 11 years ago
Milestone: | → 0.12.6 |
---|---|
Resolution: | worksforme |
Status: | closed → reopened |
I think that the issue is defect and we should fix it. In [ce33549b/jomae.git], added the regression test for this issue. After the changes, the property table in ticket notification email will be the following.
-------------------------------------------------+------------------------- Reporter: anonymous | Owner: | somebody Type: defect | Status: | closed Priority: normal | Milestone: | iter_01 Component: XXXXXXXXXXXXXXXXXXXXXXXXXX | Resolution: | fixed Keywords: | Deployment state: Privacy sensitive: 0 | Related nodes: | XXXXXXXXXX Security sensitive: 0 | Blocking: Blocked by: | Effort: | normal -------------------------------------------------+-------------------------
I'll push the changes to 0.12-stable.
comment:5 by , 11 years ago
Owner: | set to |
---|---|
Status: | reopened → assigned |
comment:6 by , 11 years ago
Release Notes: | modified (diff) |
---|
Fixed in [12344] and mergd in [12345-12346].
comment:7 by , 11 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Replying to Mitar:
When I try to reproduce the issue, the
order
setting is used.If I'm not mistaken, then here also the custom fields follow the order given in the configuration.
(Assuming this order:
and that fields may be pushed down by word wrapping.)
… and is identical to the one given here.
Not sure why owner is last here. But owner and component are not a custom field, so the
[ticket-custom]
order
presumably has nothing to do with it.Left vs. right depends on odd/even number of non-custom fields. On the web various fields (status, resolution, type) are not part of the table.
Maybe I'm missing something?