`query:?`, saved custom query and `search:` links should quote the query string

[Jun Omae]

query:?, saved custom query and search: links can be contained raw query string. Trac generates a anchor and sends Location header using the query string.

When the query string has non-ascii characters, Trac uses it without quoting.

query:?type=résumé which is saved in report sends Location: http://example.org/query?type=résumé, expects Location: http://example.org/query?type=r%C3%A9sum%C3%A9.

IE on Windows processes Location header using ANSI codepage. As a result, UnicodeDecodeError often happens.

quote-query-string.diff​.

[Jun Omae]

patch based on 0.12-stable@10757

[Remy Blank]

I'm unable to reproduce the issue with IE9, but the patch makes sense and looks good. I see one failure in the unit tests, due to a recent change where we filter out unused fields in ticket queries. The following patch fixes the issue:

trac/ticket/tests/wikisyntax.py

@@ -212 +212 @@
 
 query:verbose=1
 
-query:type=résumé
+query:summary=résumé
 ------------------------------
 <p>
 <a class="query" href="/query?order=priority">query:?order=priority</a>
@@ -239 +239 @@
 <a class="query" href="/query?order=priority&amp;row=description">query:verbose=1</a>
 </p>
 <p>
-<a class="query" href="/query?type=r%C3%A9sum%C3%A9&amp;order=priority">query:type=résumé</a>                                                                  
+<a class="query" href="/query?summary=r%C3%A9sum%C3%A9&amp;order=priority">query:summary=résumé</a>                                                            
 </p>
 ------------------------------
 ============================== TicketQuery macro: no results, list form

Please apply.

[Jun Omae]

Thanks for the review, Remy! The two patches have been committed in [10842].