#10100 closed defect (fixed)
Mixed case for ticket counts in roadmap
Reported by: | Mitar | Owned by: | Christian Boos |
---|---|---|---|
Priority: | normal | Milestone: | 1.0 |
Component: | roadmap | Version: | 0.12.2 |
Severity: | trivial | Keywords: | progress |
Cc: | mmitar@… | Branch: | |
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
In roadmap, under the milestone, where ticket counts are, active and closed counts have lower-case (active, closed), while total count has first letter upper-case (Total). Probably this should be made to have matching case.
Attachments (1)
Change History (13)
comment:1 by , 14 years ago
Milestone: | → 0.13 |
---|---|
Owner: | set to |
comment:2 by , 14 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:3 by , 14 years ago
This got me thinking, what about an even more radical change?
Instead of a <dl> where we have to repeat the link for the <dt> and the <dd>:
what about having something like:
Total of 83 tickets, among them: 54 closed, 29 active.
or simply:
comment:4 by , 14 years ago
This is then hard to process with Genshi to reformat/restructure. I would at least add some <span>
elements around.
comment:5 by , 14 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
I don't really like the current state either. Your first suggestion (or something similar, like "83 tickets in total, split into: 54 closed, 29 active") is better, but may be difficult to translate (and requires at least a plural form). I find the second suggestion hard to read.
I can't find anything much better, though.
comment:6 by , 14 years ago
Indeed, one must be very careful with the i18n aspect here, as incidentally this part was one of the most difficult to get right during 0.12dev (#8588).
The second suggestion willl perhaps be more readable with <span>s and some extra whitespace, e.g.
83 tickets: 54 closed, 29 active.
But the above is certainly still prone to the i18n problems discussed in #8588.
So perhaps:
Total number of tickets: 83 closed: 54 active: 29
Not a big change from what we have now, but no <dl> and a single link, so I think it's better.
Also, I believe the construction “Total number of tickets: 1” is correct.
by , 14 years ago
Attachment: | t10100-progress_bar-legend-r10661.diff added |
---|
simplify HTML for the progress bar legend.
follow-up: 8 comment:7 by , 14 years ago
Yes, that's quite good, actually. Is the hyphen intentional in the patch?
follow-up: 9 comment:8 by , 14 years ago
Replying to rblank:
Is the hyphen intentional in the patch?
Yes, that was a last minute addition. It suggests items in a list. Other symbols could be tried, for example:
Total number of tickets: 3 • closed: 1 • in progress: 1 • new: 1
Total number of tickets: 3 - closed: 1 - in progress: 1 - new: 1
Total number of tickets: 3 · closed: 1 · in progress: 1 · new: 1
… and nothing is still an option, of course ;-)
comment:9 by , 14 years ago
Replying to cboos:
Other symbols could be tried, for example:
No, the hyphen is fine, I was only wondering. So yes, please apply!
comment:10 by , 14 years ago
Keywords: | progress added |
---|---|
Resolution: | → fixed |
Status: | reopened → closed |
Thanks! Committed in r10662.
comment:11 by , 14 years ago
Owner: | changed from | to
---|
I don't stand a chance with my 1-character patch :)
comment:12 by , 14 years ago
Well, numerically you won, as I have a negative diffstat ;-)
(which is good, of course ;-) )
Fixed in [10660] (one-character patch, yay!).