Should be a way to differentiate external links from links to the project server

[Juanma Barranquero]

Currently, there's no way to tell apart links which are really external, i.e., http://www.microsoft.com, from the ones not in Trac, but still in the local server, like http://myproject/mypath. That's weird, because links I would consider "local" are decorated with the external icon.

I've already patched my Trac installation to differentiate them, but I'm not entirely sure that relying on the project.url setting from TracIni is the right thing to do.

trac/WikiFormatter.py

@@ -60 +60 @@
         self._href = absurls and env.abs_href or env.href
+        self._local = hdf.getValue('project.url', '')
+
+    def link_type(self, link):
+        if self._local and link.find(self._local) == 0:
+            return 'loc-link'
+        else:
+            return 'ext-link'
 
@@ -213 +220 @@
     def _url_formatter(self, match, fullmatch):
-        return '<a class="ext-link" title="%s" href="%s">%s</a>' % (match, match, match)
+        return '<a class="%s" title="%s" href="%s">%s</a>' % (self.link_type(match), match, match, match)
 
@@ -225 +232 @@
         else:
-            return '<a class="ext-link" title="%s" href="%s">%s</a>' % (link, link, name)
+            return '<a class="%s" title="%s" href="%s">%s</a>' % (self.link_type(link), link, link, name)
 

[arack99@…]

I agree. I have multiple trac's setup to manager multiple projects. I have one trac that is just for common wiki stuff that gets linked to from the others. I would like those URLS to be considered local to make it feels as if its a single system.

[Juanma Barranquero]

BTW, a change a few weeks ago broke the patch, so the first few lines should instead be:

         self._href = absurls and env.abs_href or env.href
+        self._local = env.get_config('project', 'url')

[Juanma Barranquero]

Broken again. There goes the full patch:

trac/WikiFormatter.py

@@ -58 +58 @@
         self._href = absurls and env.abs_href or env.href
+        self._local = env.get_config('project', 'url')
+
+    def link_type(self, link):
+        if self._local and link.find(self._local) == 0:
+            return 'loc-link'
+        else:
+            return 'ext-link'
 
@@ -151 +158 @@
     def _make_ext_link(self, url, text):
-        return '<a class="ext-link" href="%s">%s</a>' % (url, text)
+        return '<a class="%s" href="%s">%s</a>' % (self.link_type(url), url, text)
 

FWIW, I still think something like that should be done in Trac, not as an external patch…

[Christopher Lenz]

Slightly modified patch applied in [1232].