Edgewall Software
Modify

Opened 15 years ago

Closed 15 years ago

Last modified 13 years ago

#1001 closed defect (fixed)

"htdocs_location" shoudn't be prepended when URL starts with a Slash, or a Scheme

Reported by: clynx Owned by: Jonas Borgström
Priority: normal Milestone: 0.8.1
Component: general Version: 0.8
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:

Description

When Configuring am header_logo on another Server where the Address starts with http|https the "htdocs_location" Configuration Value if prepended

The URL gets the following for Example: /trac/http://domain.tdl/logo.png

It would be nice when Trac would check if the Address Starts with a Slash, or a Scheme, and if is exists not to prepend "htdocs_location"

Attachments (0)

Change History (2)

comment:1 by Christopher Lenz, 15 years ago

That should work. At least for your example.

core.py, line 241:

    src = env.get_config('header_logo', 'src')
    src_abs = src[:7] == 'http://' and 1 or 0
    if not src[0] == '/' and not src_abs:
        src = htdocs_location + src

I see how this would not work for https://, which should be fixed.

comment:2 by Christopher Lenz, 15 years ago

Milestone: 0.8.1
Resolution: fixed
Status: newclosed
Version: devel0.8

Fixed in [1257], ported to 0.8 stable in [1258].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jonas Borgström.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Jonas Borgström to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.