WebAdmin: severity order selection field is invalid

[eblot]

In WebAdmin, when a severity item is deleted, the drop-down list of priority order is not reset.

For example:

1. Initial severities { critical: 1, major: 2, normal: 3, minor: 4 }
2. Action: delete severity "normal"
3. Final severities { critical: 1, major: 2, minor: 4 }

-> order 3 is cannot be selected anymore.

Btw, I think a webadmin component should be added on p.e.c., as it is going to be part of the next Trac release.

[mgood]

#3555 has been marked as a duplicate.

[anonymous]

This also goes for Priority enum. I have changed these a couple of times (adding and deleting keywords and changing the order. I now have three Priority values: high, normal, wish. Their associated values are 7, 8, 9 which also breaks the coloring by priority report: all tickets are displayed in red.

[anonymous]

Another problem I have is the top value in the list cannot be moved: when i now add a priority using trac_admin, and try to priority order <name> down/up, it won't move. Are these problems connected?

[osimons]

A simple patch that sets new order (value field) to current-1 for all the values that are higher than the one being deleted:

trac/ticket/model.py

@@ -371 +371 @@
         self.env.log.info('Deleting %s %s' % (self.type, self.name))
         cursor.execute("DELETE FROM enum WHERE type=%s AND value=%s",
                        (self.type, self._old_value))
+        cursor.execute("UPDATE enum set value=value-1 where "
+                       "type=%s and value>%s", (self.type, self._old_value))
 
         if handle_ta:
             db.commit()

By doing it in the model code, it works the same for both trac-admin and webadmin usage. I only have SQLite, but should be valid syntax on all backends, I guess?

[osimons]

Replying to anonymous:

Another problem I have is the top value in the list cannot be moved: when i now add a priority using trac_admin, and try to priority order <name> down/up, it won't move. Are these problems connected?

This works fine for me - all works up and down as expected.

[osimons]

Reorder + delete default setting from trac.ini if that option is deleted (strictly not needed). Added some tests.

[osimons]

Implemented as [6317]. Ended up leaving the default setting in trac.ini as it does not interfere with anything.

Closes ticket.

[osimons]

Actually, that was not the end of it... Follow-up in #6490, hopefully finally fixed in [6323].

[osimons]

#4982 closed as duplicate.