Deleting a resource should warn that attachments will also be deleted

[Ryan J Ollos]

Specifically, when deleting a wiki page, the wiki delete page should list the attachments that will be deleted and warn that the files are not recoverable after the parent resource is deleted.

The same behavior should probably also be applied to the Milestone and Ticket resources.

[Peter Suter]

Deleting a milestone does actually not seem to delete the attachments so far. (Is this a defect? Perhaps this should be changed in a separate ticket first.)

trac/ticket/model.py

@@ -1011 +1011 @@
         with self.env.db_transaction as db:
             self.env.log.info("Deleting milestone %s", self.name)
             db("DELETE FROM milestone WHERE name=%s", (self.name,))
+            Attachment.delete_all(self.env, self.realm, self.name)
             # Don't translate ticket comment (comment:40:ticket:5658)
             self.move_tickets(retarget_to, author, "Milestone deleted")
             self._old['name'] = None

[Jun Omae]

Replying to psuter:

Deleting a milestone does actually not seem to delete the attachments so far. (Is this a defect? Perhaps this should be changed in a separate ticket first.)

Oh, that's so bad. Trac 0.12.5 has the issue. We should fix it on 0.12-stable. Please create a new ticket.

[Peter Suter]

Replying to jomae:

Oh, that's so bad. Trac 0.12.5 has the issue. We should fix it on 0.12-stable. Please create a new ticket.

OK, thanks for confirming. I created #11672.

[Ryan J Ollos]

I didn't use list_of_attachments.html​ because it seems better to present just a simple list of attachments without extra data to clutter the presentation.

If the changes look good to others I will make similar changes to:

• tags/trac-1.0.2/trac/ticket/templates/milestone_delete.html​
• tags/trac-1.0.2/tracopt/ticket/templates/ticket_delete.html​

Proposed changes in log:rjollos.git:t11542.

[Peter Suter]

Note that deleting a single version might also delete the attachments (if it is the only version).

[Ryan J Ollos]

Thanks, revised in log:rjollos.git:t11542-delete-attachments-notice.

[Ryan J Ollos]

Refactoring of the wiki_delete.html and list_of_attachments.html templates committed in [13533].

[Ryan J Ollos]

Revised changes from comment:6 committed to trunk in [13555:13556]. New extraction in [13557].

[Ryan J Ollos]

Proposed changes in log:rjollos.git:t11542-delete-attachments-notice.1. Notices have been added to the Milestone and Ticket delete pages, and some HTML validation errors fixed on the Wiki delete page.

[Ryan J Ollos]

Committed to trunk in [13601:13602].