Deleting a milestone should delete its attachments

[Peter Suter]

Deleting a milestone does not delete its attachments. (As previously discussed.)

Proposed fix:

trac/ticket/model.py

@@ -1011 +1011 @@
         with self.env.db_transaction as db:
             self.env.log.info("Deleting milestone %s", self.name)
             db("DELETE FROM milestone WHERE name=%s", (self.name,))
+            Attachment.delete_all(self.env, self.realm, self.name)
             # Don't translate ticket comment (comment:40:ticket:5658)
             self.move_tickets(retarget_to, author, "Milestone deleted")
             self._old['name'] = None

Reparenting of attachments when a milestone is renamed was previously fixed in #7933 and a unit test was added.

A similar unit test should be added for deleting attachments.

[Peter Suter]

In the attached patch I rebased the proposed fix for 0.12.6 and added a unit test.

[Ryan J Ollos]

Looks good to me. At first I thought this would just leave stray files on the filesystem, but another consequence is that attachments reappear if the milestone is deleted and recreated with the same name.

[Peter Suter]

Committed in [12927] and merged to 1.0-stable ([12928]) and trunk in ([12929]).

[Ryan J Ollos]

A side-effect of the defect in this ticket would be that the attachments directory will not be deleted on upgrade for environments in which a milestone with attachment(s) have been deleted: wiki:TracUpgrade#Attachmentsmigratedtonewlocation.

[Jun Omae]

The attachments directory will be removed even with the defect because the db28​, attachments upgrade, uses only attachment table, so it doesn't check existence of its parent resource.

$ ~/venv/trac/0.12.5/bin/trac-admin /dev/shm/t11672 initenv ticket:11672 sqlite:db/trac.db >/dev/null
$ ~/venv/trac/0.12.5/bin/trac-admin /dev/shm/t11672 milestone add foobar
$ ~/venv/trac/0.12.5/bin/trac-admin /dev/shm/t11672 attachment add milestone:foobar /etc/hosts
$ ~/venv/trac/0.12.5/bin/trac-admin /dev/shm/t11672 attachment list milestone:foobar

Name   Size       Author  Date                 Description
----------------------------------------------------------
hosts  240 bytes  trac    2014-08-18 16:31:43

$ ~/venv/trac/0.12.5/bin/trac-admin /dev/shm/t11672 milestone remove foobar
$ ~/venv/trac/0.12.5/bin/trac-admin /dev/shm/t11672 attachment list milestone:foobar

Name   Size       Author  Date                 Description
----------------------------------------------------------
hosts  240 bytes  trac    2014-08-18 16:31:43

$ sha1sum /dev/shm/t11672/attachments/milestone/foobar/hosts
4e5621cb123edf4834266219aa609bae248096e0  /dev/shm/t11672/attachments/milestone/foobar/hosts
$ ~/venv/trac/1.0.1/bin/trac-admin /dev/shm/t11672 upgrade
Upgrade done.

You may want to upgrade the Trac documentation now by running:

  trac-admin /dev/shm/t11672 wiki upgrade
$ ~/venv/trac/1.0.1/bin/trac-admin /dev/shm/t11672 attachment list milestone:foobar

Name   Size       Author  Date                 Description
----------------------------------------------------------
hosts  240 bytes  trac    2014-08-18 16:31:43

$ ls -ld /dev/shm/t11672/attachments
ls: cannot access /dev/shm/t11672/attachments: No such file or directory
$ ls -l /dev/shm/t11672
total 8
drwxr-xr-x 2 jun66j5 jun66j5 100 Aug 18 16:33 conf
drwxr-xr-x 2 jun66j5 jun66j5  80 Aug 18 16:33 db
drwxr-xr-x 3 jun66j5 jun66j5  60 Aug 18 16:33 files
drwxr-xr-x 2 jun66j5 jun66j5  40 Aug 18 16:31 htdocs
drwxr-xr-x 2 jun66j5 jun66j5  40 Aug 18 16:31 log
drwxr-xr-x 2 jun66j5 jun66j5  40 Aug 18 16:31 plugins
-rw-r--r-- 1 jun66j5 jun66j5  98 Aug 18 16:31 README
drwxr-xr-x 2 jun66j5 jun66j5  60 Aug 18 16:31 templates
-rw-r--r-- 1 jun66j5 jun66j5  27 Aug 18 16:31 VERSION
$ sha1sum /dev/shm/t11672/files/attachments/milestone/884/8843d7f92416211de9ebb963ff4ce28125932878/abba3508de929934a4e4b5198e00683c2b633bbc
4e5621cb123edf4834266219aa609bae248096e0  /dev/shm/t11672/files/attachments/milestone/884/8843d7f92416211de9ebb963ff4ce28125932878/abba3508de929934a4e4b5198e00683c2b633bbc