Changes between Version 2 and Version 3 of TracDev/Proposals/AdvancedNotification/IEmailAddressResolver

Timestamp:

Oct 6, 2013, 12:38:23 PM (11 years ago)

Author:

Peter Suter

Comment:

Fix example (unbind from ldap before returning); target milestone:1.1.2

TracDev/Proposals/AdvancedNotification/IEmailAddressResolver

@@ -1 +1 @@
 == Extension Point : ''IEmailAddressResolver'' ==
 
-||'''Interface'''||''IEmailAddressResolver''||'''Since'''||[wiki:TracDev/ApiChanges/1.1.1#IEmailAddressResolver 1.1.1]||
-||'''Module'''||''trac.notification''||'''Source'''||[source:trunk/trac/notification/api.py#/IEmailAddressResolver api.py]||
+||'''Interface'''||''IEmailAddressResolver''||'''Since'''||[wiki:TracDev/ApiChanges/1.1.2#IEmailAddressResolver 1.1.2]||
+||'''Module'''||''trac.notification''||'''Source'''||[source:psuter/trac/notification/api.py@advanced-notification-mail-distribution#/IEmailAddressResolver api.py]||
 
 The ''IEmailAddressResolver'' is a fallback mechanism for determining which email address should be used to send [TracNotification notifications].
@@ -39 +39 @@
     
     def get_address_for_session(sid, authenticated):
+        address = None
         ld = ldap.initialize('ldap://localhost:1390')
         ld.simple_bind_s()
@@ -46 +47 @@
                                      ['mail']):
             if 'mail' in entry:
-                return entry['mail']
+                address = entry['mail']
         ld.unbind_s()
+        return address
 }}}
 
@@ -65 +67 @@
    * DONE Renamed `get_address_for_name()` to `get_address_for_session()`.
    * DONE Other distributors can not use the same interface (according to comment in th:AnnouncerPlugin's `XmppDistributor`) so this is email specific.
-   * TODO: Make it usable by multiple distributors?
+   * TODO: Make it usable by distributors other than email?