Changes between Version 1 and Version 2 of TracDev/Proposals/AdvancedNotification/DatabaseSchema

Timestamp:

Oct 12, 2013, 5:25:08 PM (11 years ago)

Author:

Peter Suter

Comment:

Raise some questions about the proposed DB schema

TracDev/Proposals/AdvancedNotification/DatabaseSchema

@@ -25 +25 @@
 Use the `trac.notification.model.Subscription` model class to access this table. 
 
+Note that this table does not store an (email) address, but the commonly used subscription tuple has an additional item `addr`. Usually such tuples that correspond to entries in this DB table contain a `addr` of `None. Other tuples may contain an (email) address (e.g. retrieved from  a ticket CC field) but are missing the `sid` item instead.
+
 See [browser:psuter/trac/notification/model.py@advanced-notification-subscriptions#/ trac.notification.model.Subscription]
 
@@ -44 +46 @@
 
 See [browser:psuter/trac/notification/model.py@advanced-notification-subscription-attributes#/ trac.notification.model.SubscriptionAttribute]
+
+== Open Questions
+
+=== Rename `class` column?
+
+Something like `rule` might be more appropriate.
+
+See also [wiki:TracDev/Proposals/AdvancedNotification/INotificationSubscriber#Removeclassname INotificationSubscriber].
+
+=== Rename tables?
+The current table names are taken from the th:AnnouncerPlugin.
+
+Would this cause problems for users that already used that plugin?
+
+=== Remove `time` and `changetime` columns?
+These are not really needed.