Changes between Version 9 and Version 10 of NewWorkflow

Timestamp:

Nov 15, 2004, 9:13:20 PM (19 years ago)

Author:

pkou <pkou at ua.fm>

Comment:

New patch that includes refactoring of ticket-specific code in order to support customized workflows

NewWorkflow

@@ -13 +13 @@
 
 List of attachments:
- * '''patch-newworkflow-r1040.diff''': Source code patch for Trac;
+ * '''patch-newworkflow-r1064.diff''': Source code patch for Trac;
  * '''closedticket.png''': Updated icon for closed tickets in timeline;
  * '''resolvedticket.png''': New icon for resolved tickets in timeline;
@@ -29 +29 @@
 This documents includes description and implementation of new workflow system that resolves this issue for ''Trac''.
 
-It is still possible to use existing workflow with these changes. The new workflow does not remove existing workflow.  Workflow version is configured in ''trac.ini'' via property ''workflow_version''.
+It is still possible to use existing workflow with these changes. The new workflow does not remove existing workflow.  Workflow is configured in ''trac.ini'' via property ''workflow''.
 
 == Workflow Transitions ==
@@ -97 +97 @@
    1. Refresh source code tree from http://svn.edgewall.com/repos/trac/trunk;
    1. Apply attached patch;
-   1. Add attached files '''closedticket.png''', '''resolvedticket.png''', and '''reopenedticket.png''' to directory '''htdocs''';
-   1. Install Trac by running '''setup.py install'''
- 1. Upgrade every project by running '''trac-admin ''project-path'' upgrade''';
+   1. Add attached files {{{closedticket.png}}}, {{{resolvedticket.png}}}, and {{{reopenedticket.png}}} to directory {{{htdocs}}};
+   1. Install Trac by running {{{setup.py install}}}
+ 1. Upgrade every project by running {{{trac-admin project-path upgrade}}};
  1. Settings for several predefined reports are overridden during the upgrade.  If standard reports have been customized for a project, then it is necessary to repeat the customization using the following steps:
-   1. Go to directory ''' ''project-path''/db''';
+   1. Go to directory {{{project-path/db}}};
    1. Dump existing reports by running {{{sqlite trac.db ".dump report" > dump.new}}}
    1. Dump original reports by running {{{sqlite trac.db.7.bak ".dump report" > dump.old}}}
@@ -110 +110 @@
      1. Review and modify ''components''. Specify '''owner''' and '''qaowner''' for every component;
      1. Review and modify ''milestones''. Specify '''owner''' for every milestone.
-   1. Finally, edit''' ''project-path''/conf/trac.ini''' and change property '''workflow_version''' to '''2''' (section '''ticket''');
+   1. Finally, edit {{{project-path/conf/trac.ini}}} and change property '''workflow''' to '''trac.workflows.QaRmtWorkflow''' (section '''ticket''');
 
 == Modified Files and Detailed Release Notes ==
@@ -116 +116 @@
 Many files have been modified and below list describes the changes.  The patch is also available.
 
- * Files '''wiki-default/TracIni''', '''wiki-default/TracAdmin''', '''scripts/trac-admin''', '''trac/db_default.py''', '''trac/Environment.py'''; Added '''trac/upgrades/db8.py''':
-   * Property ''workflow_version'' added to ''trac.ini'', section ''tickets'':
-     * For new projects and by default, it equals to '''2''' and new workflow is used;
-     * For upgraded projects, it equals to '''1''' and current (old) workflow is used;
-     * The version of workflow can be changed at any time.
+=== Refactoring of Trac code for easy support of customized workflows ===
+
+ * File {{{wiki-default/TracIni}}}:
+   * Property ''workflow'' added to ''trac.ini'', section ''tickets'':
+     * The property specifies class name that implements workflow for Trac;
+     * By default, it equals to '''trac.workflows.SimpleWorkflow''' and current workflow is used.
+ * File {{{setup.py}}}; Added {{{trac/workflows/__init__.py}}}:
+   * Install additional directory ''trac/workflows'', which contains predefined implementations of workflows for Trac.
+ * Added {{{trac/workflows/Base.py}}}:
+   * Abstract base class for any workflow.  All workflow implementations should be derived from it.
+ * Added {{{trac/workflows/SimpleWorkflow.py}}}, {{{templates/ticket_workflow_simple.cs}}}:
+   * Implementation of standard workflow (as in Trac 0.8).
+ * Files {{{trac/Ticket.py}}}, {{{templates/ticket.cs}}}, {{{templates/newticket.cs}}}:
+   * Code refactoring for customized workflow usage;
+   * Workflow-specific code has been moved to {{{trac/workflows/SimpleWorkflow.py}}} and {{{templates/ticket_workflow_simple.cs}}};
+   * Visible enhancements:
+     * Better error handling: If validation of a ticket is failed, then the ticket is displayed in preview mode automatically with explanation of errors;
+     * Custom fields are preserved in preview mode (see #930 also).
+
+=== Changes for new workflow ===
+
+ * Files {{{wiki-default/TracAdmin}}}, {{{scripts/trac-admin}}}, {{{trac/db_default.py}}}, {{{trac/upgrades/__init__.py}}}; Added {{{trac/upgrades/db8.py}}}:
    * New ticket statuses ''resolved'' and ''verified'' added:
      * Status ''resolved'' is used by QA for testing;
@@ -142 +159 @@
        * ''Resolved Tickets by Owner''.
      * For processing verified and closed defects by Release Manager:
-       * ''Verified Tickets by Milestone (Full Description)''.
+       * ''Completed Tickets by Milestone (Full Description)''.
    * Default report ''All Tickets by Milestone'' renamed to ''Active Tickets by Milestone'' because existing name does not correspond to what is produced by the report;
    * Default report ''My Tickets'' updated so that new statuses are queried;
@@ -148 +165 @@
      * '''Not Assigned''' displayed as group name for empty ''owner'' or ''milestone'';
      * '''Not Specified''' displayed as group name for empty ''version'';
-   * Database version changed to '''8'''.  Affected tables including reports are updated during database upgrade.  Old workflow is used by default after the upgrade.
-
- * Files '''trac/Ticket.py''', '''templates/ticket.cs''':
-   * New workflow is used when ''workflow_version'' equals to '''2''' in ''trac.ini'', section ''ticket''.  See separate chapter '''Workflow Transitions''' for details;
-   * Owner is calculated automatically when statuses are changed.  The cacluation depends on currently logged user, status, component owner, component qaowner, milestone owner, and ticket reporter.  See separate section '''Automatic Ticket Assignment''' for details;
-   * Displayed ticket actions depend on current workflow version;
-
- * Files '''trac/Milestone.py''', '''trac/Roadmap.py''', '''templates/roadmap.cs''', '''templates/milestone.cs''':
+   * Database version changed to '''8'''.  Affected tables including reports are updated during database upgrade;
+   * Old workflow is used by default after the upgrade.  New workflow is used by default for new projects.
+
+ * Files {{{trac/workflows/__init__.py}}}; Added {{{trac/workflows/QaRmtWorkflow.py}}}, {{{templates/ticket_workflow_qarmt.cs}}}:
+   * Implementation of new workflow.  See separate chapters '''Workflow Transitions''' and '''Automatic Ticket Assignment''' for details.
+
+ * File {{{templates/ticket.cs}}}:
+   * Display resolution in ticket header when it is available (currently, the resolution is displayed for closed tickets only).
+
+ * Files {{{trac/Milestone.py}}}, {{{trac/Roadmap.py}}}, {{{templates/roadmap.cs}}}, {{{templates/milestone.cs}}}:
    * Word '''resolved''' is replaced with word '''completed''' in order to eliminate conflict with status ''resolved'';
    * New statuses used when percentage is calculated:
@@ -164 +183 @@
    * New statuses are taken into account when information is downloaded in ''iCalendar'' format.
 
- * Files '''htdocs/css/timeline.css''', '''htdocs/closedticket.png''', '''trac/Timeline.py''', '''templates/timeline_rss.cs''', '''templates/timeline.cs'''; Added '''htdocs/resolvedticket.png''':
+ * Files {{{htdocs/css/timeline.css}}}, {{{htdocs/closedticket.png}}}, {{{trac/Timeline.py}}}, {{{templates/timeline_rss.cs}}}, {{{templates/timeline.cs}}}; Added {{{htdocs/resolvedticket.png}}}, {{{htdocs/reopenedticket.png}}}:
    * The ''resolved'' and ''verified'' tickets added to timeline when new workflow is used;
    * ''Milestone owner'' is retrieved from database for RSS;
    * New icons are used for ''resolved'', ''closed'', and ''reopened''/''retested'' tickets in timeline.
 
- * File '''trac/Wikiformatter.py''':
+ * File {{{trac/WikiFormatter.py}}}:
    * Ticket status is displayed in popups for ticket numbers.
 
@@ -183 +202 @@
 == Patch History ==
 
+ * '''patch-newworkflow-r1040.diff''': Patch that does not include refactoring in {{{Ticket.py}}} in order to support customized workflows.
  * '''patch-newworkflow-r1034.diff''': Patch that includes one more non-related change (see #905 for details).  There are no more changes to remove! :-)
  * '''patch-newworkflow-r1016.diff''': Patch that includes one more non-related change (see #892 for more details).  Also, this patch has merge conflicts with current codebase.  Also, this patch does not contain support for separate icon for reopened/retested tickets.