Edgewall Software

Opened 11 years ago

Closed 11 years ago

Last modified 9 years ago

#9607 closed enhancement (fixed)

Rework branch labeling in the timeline — at Version 4

Reported by: Christian Boos Owned by: Christian Boos
Priority: normal Milestone: 1.0
Component: version control Version: 0.13dev
Severity: normal Keywords: branch tag label
Cc: Branch:
Release Notes:

Timeline: the changesets entries display their associated tags, if any

API Changes:

versioncontrol: added Changeset.get_tags() [10077]

Internal Changes:

Description (last modified by Christian Boos)

In #8843, we added the possibility to display the branch information for each changeset in the timeline.

However, it doesn't look that nice when we also display the list of changed files inline: Example for #8843, as it looks like in Trac 0.12

It would be better to show this label like the gitweb and the hg web interfaces do, after the changeset number, not on the next line.

A second (minor) issue with the above is that we always show the default label for Mercurial repositories. I ended up using a simple ignore list (default, master).

With display-branch-in-event-title-r9966.patch, we have: New layout for the branch labels

A second step is to add support for displaying the tag labels.

With display-tags-in-changeset-events-r9966.patch, we have: Show the tag labelsShow the tag labels (a bit further down in the history)

Change History (10)

by Christian Boos, 11 years ago

Attachment: timeline-8843.png added

Example for #8843, as it looks like in Trac 0.12

by Christian Boos, 11 years ago

New layout for the branch labels

by Christian Boos, 11 years ago

Show the tag labels

by Christian Boos, 11 years ago

Show the tag labels (a bit further down in the history)

by Christian Boos, 11 years ago

display branch name label in the timeline event's title line instead of its description. Applies on r10060.

by Christian Boos, 11 years ago

display tag labels for the changeset events in the timeline. Applies on display-branch-in-event-title-r9966.patch.

comment:1 by Christian Boos, 11 years ago

Description: modified (diff)

comment:2 by Christian Boos, 11 years ago

Remy, your comment on this, please? ;-)

comment:3 by Remy Blank, 11 years ago

I don't have time to dive into the code ATM, but the result is very nice.

comment:4 by Christian Boos, 11 years ago

API Changes: modified (diff)
Release Notes: modified (diff)
Resolution: fixed
Status: newclosed

Well, the code was cleaned up during the process of creating this ticket (I previously had some filtering arguments in get_branches() I was not fully convinced about), so my remaining question mark was more if you liked the final result ;-)

Applied in [10076:10077].

Note: See TracTickets for help on using tickets.