Context Navigation

#9453 closed defect

Reported by:	Jun Omae	Owned by:
Priority:	normal	Milestone:	1.0
Component:	general	Version:	0.11
Severity:	normal	Keywords:
Cc:	leho@…, Thijs Triemstra, osimons	Branch:
Release Notes:
API Changes:
Internal Changes:

When the session is modified and response with req.send(), the session does not be saved.

The patch adds self.session.save() to check_modified, send and send_file excluding send_error.

Trac 0.12 and Trac 0.11-stable have the same issue.

diff --git a/trac/web/api.py b/trac/web/api.py
index df6d9ac..b3becbd 100644

                class Request(object):
         if (not inm or inm != etag):
             self.send_header('ETag', etag)
         else:
+            self.session.save()
             self.send_response(304)
             self.send_header('Content-Length', 0)
             self.end_headers()
-…
+               class Request(object):
         self.send(data, content_type, status)
     def send(self, content, content_type='text/html', status=200):
+        self.session.save()
         self.send_response(status)
         self.send_header('Cache-Control', 'must-revalidate')
         self.send_header('Content-Type', content_type + ';charset=utf-8')
-…
+               class Request(object):
         mtime = datetime.fromtimestamp(stat.st_mtime, localtz)
         last_modified = http_date(mtime)
         if last_modified == self.get_header('If-Modified-Since'):
+            self.session.save()
             self.send_response(304)
             self.send_header('Content-Length', 0)
             self.end_headers()
-…
+               class Request(object):
             mimetype = mimetypes.guess_type(path)[0] or \
                        'application/octet-stream'
+        self.session.save()
         self.send_response(200)
         self.send_header('Content-Type', mimetype)
         self.send_header('Content-Length', stat.st_size)

Note: See TracTickets for help on using tickets.