Edgewall Software

Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#9371 closed enhancement (fixed)

tracd --basic-auth doesn't work for SHA passwords — at Version 10

Reported by: Daniel Musketa <daniel@…> Owned by: Jun Omae
Priority: high Milestone: 1.0
Component: web frontend/tracd Version: 0.12dev
Severity: normal Keywords: bitesized
Cc: Branch:
Release Notes:

tracd: basic authentication now supports SHA1 passwords

API Changes:
Internal Changes:

Description

tracd --basic-auth works for passwords generated by htpasswd in crypt (which is linux default) or md5 (option -m) mode, but not for passwords generated in SHA (option -s) mode.

How to reproduce

# create a fresh env
trac-admin trac-env/ initenv

# create file for auth (user=passwd=mode)
echo crypt:PgjnZnmDQ8S7w >> .htpasswd
echo md5:$apr1$PjxHNVvY$41a7qPozEZ1b47OomFoos/ >> .htpasswd
echo sha:{SHA}2PRZAyDhNDqRW2OUFwZQqPNdaSY= >> .htpasswd

# run tracd
tracd --basic-auth=trac-env,.htpasswd, --port 8000 --hostname 0.0.0.0 trac-env &
Login as user HTTP
crypt 200
md5 200
sha 401

Change History (11)

comment:1 by Remy Blank, 14 years ago

Component: generalweb frontend/tracd
Keywords: bitesized added
Milestone: unscheduled
Type: defectenhancement

Nice bite-sized enhancement request.

by Jun Omae, 14 years ago

SHA password patch (r9871)

comment:2 by Jun Omae, 14 years ago

I created the patch including unittest that supports SHA password. - t9371-sha-password-r9871.diff

Please apply it, if you can.

comment:3 by Remy Blank, 14 years ago

Milestone: unscheduled0.12.1
Owner: set to Remy Blank

Thanks for the patch.

comment:4 by Christian Boos, 14 years ago

Milestone: 0.12.10.13
Owner: changed from Remy Blank to Jun Omae

Thanks jomae, we'll apply it on trunk soon.

in reply to:  4 ; comment:5 by Remy Blank, 14 years ago

Owner: changed from Jun Omae to Remy Blank

Replying to cboos:

Thanks jomae, we'll apply it on trunk soon.

Just a note: I set the owner to myself as a "to do" list, and set it back to the real owner once I close the ticket. If you reassign it, it disappears from my radar.

in reply to:  5 comment:6 by Christian Boos, 14 years ago

Replying to rblank:

Replying to cboos:

Thanks jomae, we'll apply it on trunk soon.

Just a note: I set the owner to myself as a "to do" list, and set it back to the real owner once I close the ticket. If you reassign it, it disappears from my radar.

Oh right, sorry. I plan to branch 0.12-stable at some point this week-end.

comment:7 by Remy Blank, 14 years ago

Priority: normalhigh

comment:8 by Remy Blank, 14 years ago

Resolution: fixed
Status: newclosed

Perfect patch, applied in [10028]. Thanks!

comment:9 by Remy Blank, 14 years ago

Owner: changed from Remy Blank to Jun Omae

comment:10 by Christian Boos, 14 years ago

Release Notes: modified (diff)
Note: See TracTickets for help on using tickets.