Missing import in deploy_trac.fcgi

[ebourg@…]

deploy_trac.fcgi calls sys.stdout but doesn't import sys, the Apache error.log reports it:

NameError: name 'sys' is not defined: /var/www/projects/myproject/cgi-bin/trac.fcgi

Due to this stacktraces are displayed in the Apache log and not on the web page.

[Ryan J Ollos]

Good catch. Looks like it was overlooked in r17541 / #13403.

We should likely fix it before releasing 1.6.

[Jun Omae]

The fastcgi script writes traceback of the exception which formatted "Content-Type: text/plain", however the output is received by the process that started the fascgi script (e.g. mod_fcgid), not the web client. So that I don't think the script needs to catch and format the exception.

trac/web/templates/deploy_trac.fcgi

@@ -15 +15 @@
 {##}#
 {##}# Author: Jonas Borgström <jonas@edgewall.com>
 
-try:
+def main():
     import os
     import pkg_resources
     if 'TRAC_ENV' not in os.environ and \
@@ -30 +30 @@
         pkg_resources.set_extraction_path(egg_cache)
     from trac.web import fcgi_frontend
     fcgi_frontend.run()
-except SystemExit:
-    raise
-except Exception as e:
-    print("Content-Type: text/plain", end="\r\n")
-    print("", end="\r\n")
-    print("Oops...")
-    print("")
-    print("Trac detected an internal error:")
-    print("")
-    print(e)
-    print("", flush=True)
-    import traceback
-    traceback.print_exc(file=sys.stdout)
+
+if __name__ == '__main__':
+    main()

[Jun Omae]

Fixed in [17688] and merged in [17689].